Greg Korba

Results 540 comments of Greg Korba

There is no such thing like "never stale topic", since everything can be implemented/fixed in any PR which is not linked to the issue and the issue may be left...

If it was rejected, it would be closed. It just requires action from the author. Personally I did not have time and motivation to handle this myself, as I had...

Update 2023: there's [`Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer`](https://github.com/symplify/coding-standard/blob/main/docs/rules_overview.md#linelengthfixer) as an alternative solution.

Thanks @ruudk for the feedback! Yeah, I also find ECS approach better, it allows navigating from the config to the fixer and is more explicit. Anyway, Fixer expects that custom...

I'll keep this open, but I believe we should split it to multiple issues or at least description should be refreshed, so DoD is clear. As far as I understand...

FYI: found a nice userland alternative: [`PedroTroller/line_break_between_method_arguments`](https://github.com/PedroTroller/PhpCSFixer-Custom-Fixers?tab=readme-ov-file#pedrotrollerline_break_between_method_arguments). Can be used both for usage and as an inspiration for design/implementation.

Sorry @bachinblack for not pushing this forward, but it's impossible to review and process everything, I need to prioritise things I do here as I have limited time. Parallel runner...

@jlecordier It's not like we want "a fixer to do it all". We like atomic, single-responsibility rules. They don't need to cover all the cases from day one, but similar...

@bachinblack this is buggy test related to parallel runner, we need to improve it as it sometimes fails and need to be re-run. Please ignore it for now. More interesting...

FYI: reproduced on v3.16.1, fixer responsible for this change is `phpdoc_trim_consecutive_blank_line_separation`.