Remove unneeded parentheses in phpdoc

[mvorisek]

Feature request

Thanks to #6796 parenthesised phpdoc support has been added. This is a feature request to remove unneeded parentheses in phpdoc.

Example:

@var ((A|B)&(C))

and I expect the following fix:

@var (A|B)&C

[keradus]

mind to propose a PR, @mvorisek ?

[mvorisek]

I do not plan a PR for this by myself.

[github-actions[bot]]

Since this issue has not had any activity within the last 90 days, I have marked it as stale.

I will close it if no further activity occurs within the next 30 days.

[mvorisek]

@Wirone please label this so the stale bot stays silent

[Wirone]

@mvorisek I won't do it, and please stop pointing out Stale Bot in each issue. The whole purpose of this action is to enforce backlog review once in a while, and labelling issues to skip it does not make sense. For now, there is only one scenario when we don't want Stale Bot to enter: milestone long-term-ideas with some kind of architectural plan for the future. Other issue and PRs will be under Stale Bot so we can verify quarterly if they're relevant (I pointed it out already, but I edited your comment so you could have miss it). Many times issues were fixed but were not closed because there wasn't reference (recent example). This action is mostly for maintainers and I process every issue/PR marked as stale, so you really don't need to do anything, but you can help if you want, by providing information about current relevancy, so I have less to do 🙂. But please don't ping me and ask for skipping Stale Bot.

[keradus]

It could also be that idea is valid, but very little interest of community (eg nobody implementing) and out of focus for core team. Should we keep it open indefinitely, or let to close it as stale, and recover when it will get some attention (eg more community demand or someone creating the effort).

With that, I would identify stale issue to be "totally not a priority" (or already solved but forgot to close) and not "idea rejected, it is not allowed to go this path, we will never merge a PR for it"

[mvorisek]

I feel really bad to hear this. The noise from bots is really not good, as it only distracts [1] [2]. If they close any issue, someone else will recreate another one sooner or later. Almost noone looks in the closed ones.

[1] some issues take years to fix/implement, should the discussions be really messed with stale bot posts every few months?

[2] I have 18 active/opened issues here. Please, do something, I do grant any permission to any bot to distract me every 5 (90 / 18) days.

https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/5950#issuecomment-1674646447

this is not for stale bot, this is for humans, issues can be easily ordered by "Least recently updated" and reviewed - without any noise for other if the issues are still relevant and no action is needed

[Wirone]

@mvorisek I know how to use filters, but I don't want to review whole backlog all the time. I need an automated support to focus only on things that require real attention. I've proposed better explanation from Stale Bot in #7236 which should make it more clear to users.

If they close any issue, someone else will recreate another one sooner or later. Almost noone looks in the closed ones.

Issue/PR won't be closed if there's any activity, so any of the interested users can comment, then status/stale will be removed and status/to verify will be added so maintainers can take a look at it again. Besides external activity, I process every stale notification I get (see below), but it takes time so don't expect instant reaction every time 🤷‍♂️.

some issues take years to fix/implement, should the discussions be really messed with stale bot posts every few months?

It's not the final configuration of stale bot, we can tweak it in the future to exclude more issue from the bot, but we're still processing current backlog (when I started there were more than 300 issues). Anyway, when I process stale issues I hide comments from Bot so the timeline is cleaner. When we reduce backlog and it's easier to keep track of every opened issue/PR, we can get rid of Bot, but for now it's helpful from maintenance point of view.

[2] I have 18 active/opened issues here. Please, do something, I do grant any permission to any bot to distract me every 5 (90 / 18) days.

I have notifications for the whole repo, so not only for mine, but also any other issues/PRs, yours too. I believe it's a part of being a maintainer, but please understand that there is also other side of that - to make it easier, I need automation.

PS. I'll mark our comments ass off-topic, if you want to discuss it further consider creating discussion.

[mvorisek]

In short, I would be very helpful if my efford in submitted issues and PRs will be valued and my brain saved from bots.

Based on your post, the bot is helpfull for you to review the issues on periodic basis. IIRC, addition/removal of GH label does not trigger notification. So the bot should actually not post any post. Then you can filter on the stale bot label. If relevant, you can close it, let the author know, and if not, remove the label, bot will kick in the next 90 days. Everyone will be happy.

[Wirone]

It's not only about me, bot messages trigger notification for all subscribed people so re-triage is spread across several people potentially interested in issue/PR. Many people reacted to this notification in a way that allowed me to close the issue after their feedback. Without this notification I would need to periodically check list of issues/PRs with status/stale label, which requires different approach - I already need to do like this for status/to verify and it's not the best one IMHO. I believe it's not that much to get few notifications every 3 months, but you can always opt-out from comments and subscribe only to status changes:

But thanks for that suggestion, I'll keep it in mind.

[github-actions[bot]]

Since this issue has not had any activity within the last 90 days, I have marked it as stale.

The purpose of this action is to enforce backlog review once in a while. This is mostly for maintainers and helps with keeping repository in good condition, because stale issues and PRs can accumulate over time and make it harder for others to find relevant information. It is also possible that some changes has been made to the repo already, and issue or PR became outdated, but wasn't closed for some reason. This action helps with periodic review and closing of such stale items in automated way.

You may let maintainers handle this or verify current relevancy by yourself, to help with re-triage. Any activity will remove stale label so it won't be automatically closed at this point.

I will close it if no further activity occurs within the next 30 days.

[github-actions[bot]]

Since this issue has not had any activity within the last 90 days, I have marked it as stale.

The purpose of this action is to enforce backlog review once in a while. This is mostly for maintainers and helps with keeping repository in good condition, because stale issues and PRs can accumulate over time and make it harder for others to find relevant information. It is also possible that some changes has been made to the repo already, and issue or PR became outdated, but wasn't closed for some reason. This action helps with periodic review and closing of such stale items in automated way.

You may let maintainers handle this or verify current relevancy by yourself, to help with re-triage. Any activity will remove stale label so it won't be automatically closed at this point.

I will close it if no further activity occurs within the next 30 days.

[mvorisek]

dear bot, this is never stale topic

[Wirone]

There is no such thing like "never stale topic", since everything can be implemented/fixed in any PR which is not linked to the issue and the issue may be left open while it should be closed. As described in Stale bot's comment, the purpose of this is to be able to clear the backlog from outdated stuff. Yes, there's workaround that tells Stale Bot to ignore issue, but this particular report does not match criteria to be included in the topic/core. Just accept it 😉.

[github-actions[bot]]

Since this issue has not had any activity within the last 90 days, I have marked it as stale.

The purpose of this action is to enforce backlog review once in a while. This is mostly for maintainers and helps with keeping repository in good condition, because stale issues and PRs can accumulate over time and make it harder for others to find relevant information. It is also possible that some changes has been made to the repo already, and issue or PR became outdated, but wasn't closed for some reason. This action helps with periodic review and closing of such stale items in automated way.

You may let maintainers handle this or verify current relevancy by yourself, to help with re-triage. Any activity will remove stale label so it won't be automatically closed at this point.

I will close it if no further activity occurs within the next 30 days.

[github-actions[bot]]

The fact this was automatically closed doesn't mean that the idea got rejected - it simply didn't get any priority for way too long to keep it open. If you're still interested in this, please let as know, we can consider re-opening it.

[mvorisek]

let's keep this PR open

[keradus]

this request is not considered as priority for core team members and nobody is working on it for over a year. let's keep this issue closed.

this still doesn't prevent brave hero to work on implementation and have this incorporated into the codebase!