Greg Korba
Greg Korba
@niklam whole PR is squash into 1 commit, so it doesn't matter how your branch looks like, it's only important to make it up-to-date with base branch 🙂.
@keradus @kubawerlos LGTM, but I won't merge it without your final opinion.
@niklam don't worry, I am also interested in getting this merged. But we need to wait for @keradus who has final word on such architectural changes, but he's on vacation...
@niklam I've let myself update this branch - provided some fixes to satisfy current QA suite, added more test cases, used validator for built-in rule sets registration, but also modified...
I'm going to close this one since the context of the issue has changed. @muuvmuuv feel free to open feature request with what @SpacePossum said [here](#issuecomment-1229128990) if you still need...
@keradus I'm going to close this as it seems to be stale for a long time, and keeping it as a reminder did not work 😉. It can be recovered...
@SuperDJ any chance for a rebase? It's good that you share your work through [custom fixer](https://github.com/SuperDJ/spaces-in-parentheses-php-cs-fixer), but I believe it would be beneficial to have it in the core. If...
@SuperDJ fair enough 🙂. Personally I want to merge it, but I did not review it completely and I can't promise you that it will be merged as-is. Naming is...
Daughter woke up during refactor and I missed some places, I'll fix it later 😉.
At this point the only things missing: - integration tests - code review 😉 The latter can be done already, please remember it's not my code and even I did...