Greg Korba

Results 540 comments of Greg Korba

@mvorisek I believe @kubawerlos would love to "fix all places" but as far as I understand test cases in his PR don't cover `+` added by you, so either you...

I can update @kubawerlos' PR but I'll let him decide if he wants to incorporate @mvorisek's PR before the rebase and merge here 🙂.

This somehow overlaps with sunsetting the support for mixed content (see [this comment](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/6788#issuecomment-1438688702)). It would be great to cover basic scenario (only whitespace before opening tag) though.

@HypeMC I've rebased your branch to keep PR up to date and it seems like it requires some attention - we recently introduced auto-review test that enforces tests' naming convention,...

@HypeMC I'll remove last commit because FQCN resolver seems to be incomplete, as it does not resolve properly names when multiple namespaces are used: ![image](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/assets/600668/d7eb2118-9c8d-4398-80b8-286e9f2bc382) Also, it should be `FullyQualifiedNameResolver`...

@jorismak default chunk size is 10, so in your case it's ~50 chunks distributed across available workers. But **it's configurable** (amount of cores, chunk size, timeout) 😉.

@HypeMC I did some refactoring to shorten the feedback cycle. It's close to what I would consider ready for merge, I want to try refactor one more thing but I...

I've renamed strategy to `custom` as this reflects the intent better. `none` strategy is... when you don't use this rule 😉.

@julienfalque thank you very much for the review ❤️. I'll address your comments soon. In terms of tests, I thought about running separate job in CI workflow that would run...

Parallel analysis with full caching support: ![phpcsfixer-parallel-cache](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/assets/600668/90e5fdfd-c8f3-4961-9e5d-a614da863e27) 🥳