Sam Van Campenhout

Results 72 comments of Sam Van Campenhout

We're also running into this. We use ember-intl in an addon and allow apps to set the prefered language, if they don't want the default (which is `en-us`). But after...

Looking further, it seems to be caused by the `@dependentKeyCompat` decorator: https://github.com/ember-intl/ember-intl/blob/701e0806be06ed484d7c4030b2f53b2cc251b7b0/ember-intl/addon/services/intl.js#L50 After accessing `this._locale` directly or removing `dependentKeyCompat` from the getter the error isn't triggered either. (I still think...

@NullVoxPopuli it seems one of the issues is the timeout on windows. I can increase the value again, but there seem to be some snapshot mismatches as well which didn't...

Yea, but I tried to find the version that you last used to update the snapshots and 5.1 seemed to pass the tests locally. It also doesn't fail under ubuntu-latest....

Doing some open PR cleanup, and I don't really have time / motivation to push this over the finish, so I'm closing instead. Sorry!

This commit seems to add the needed configuration: https://github.com/ember-learn/cli-guides/commit/2b376bcd9e3d9d1eae4eb3a669221faed9a16017 So I think this issue can be closed?

I just set up a new device and still had to configure the permissions in the extension settings. I'm not sure if the issue wasn't resolved by #2517 or if...

@pabloascarza Does your addon list ember-auto-import v2 as a dependency? I think that's a requirement to use v2 addons.

Could we also change the config so it only uses single quotes for js/ts code and doubles for everything else? We did a similar change in the v1 and app...

Isn't this one of the known caveats of the TS support in Ember? - https://github.com/typed-ember/ember-cli-typescript?tab=readme-ov-file#account-for-addon-build-pipeline-changes - https://github.com/typed-ember/ember-cli-typescript/issues/780 I wouldn't expect this to work under classic either then, but maybe that...