Sam Van Campenhout

Results 72 comments of Sam Van Campenhout

> tl;dr: content-tag needs to be at least 3.1.2, else you hit the missing export default bug This PR literally includes the 3.1.2 version bump and it didn't fix the...

> Where does this happen? Here: https://github.com/ember-cli/ember-cli/blob/487ae48c517597aad20970f1471b6883f8b8fa7c/lib/models/blueprint.js#L539-L576

> Maybe content-tag-utils should have an unprocess method that converts plain js/ts back to gjs/gts. > > That way strip-babel-types can operate on plain js, and we don't need parse...

Awesome, thank you for working on this! > I'm not a typescript user, I used the typescript blueprint, but I don't know how to move the [current types](https://github.com/emberjs/ember-render-modifiers/tree/master/types) into this...

I think the embroider scenarios fail because something is still bringing in ember-source v5. Probably because their ember-source peerDep doesn't support v6 yet. If you run the scenario locally with...

It seems some other changes might be needed to support async relationships in ember-data v5 as well. `PromiseManyArray` no longer has array methods in ember-data v5, which the addon seems...

> do you happen to know if this ever worked? I don't think so, no. As far as I know it has been an issue since `@model` was introduced, which...

I did some sleuthing and it does look like an Embroider issue. I pinned it down to this line in `@embroider/vite`: https://github.com/embroider-build/embroider/blob/ce85dfc338459fb72dc70a6ea7475db78f018b81/packages/vite/src/resolver.ts#L220 With `foundFile` set to `'node_modules/ember-headless-form/dist/-private/components/field.js'`, `target` will become...

> [@Windvis](https://github.com/Windvis) working on shifting an app into Embroider and saw your writeup here. Looking at the latest Embroider resolver, it looks like this is still an issue? Did we...

@NullVoxPopuli What's the blocker for this one? Does it just need more work or was it discussed somewhere and put on hold?