addon-blueprint icon indicating copy to clipboard operation
addon-blueprint copied to clipboard

Run prettier separately

Open NullVoxPopuli opened this issue 1 year ago • 1 comments

Please review per commit. We have not been running prettier on this repo, so the changes are bigger than normal.

We also get additional errors with prettier in the addon, (seen in #138)

Context:

  • Unblocks: https://github.com/embroider-build/addon-blueprint/pull/138#issuecomment-1682161854
  • Original: https://github.com/embroider-build/addon-blueprint/pull/180

Benefits:

  • eslint is faster
  • aligns with prettier recommendations
  • allows for managing script order and/or task caching if someone were to use a tool like turbo or nx

NullVoxPopuli avatar Aug 17 '23 12:08 NullVoxPopuli

Could we also change the config so it only uses single quotes for js/ts code and doubles for everything else?

We did a similar change in the v1 and app blueprint a while ago: https://github.com/ember-cli/ember-cli/pull/10062/files

I was planning to PR it but it seems that will most likely conflict with this one 😄. This is what I did to support gjs in a v1 addon, but for v2 we probably need to add .cjs and .mjs as well?:

Windvis avatar Oct 14 '23 21:10 Windvis