Sam Van Campenhout
Sam Van Campenhout
@mikeelemuel Could you check if you have multiple major versions of ember-modifier installed? `npm ls ember-modifier` or with something like [ember-dependency-lint](https://github.com/salsify/ember-cli-dependency-lint). In classic builds, multiple versions could cause strange issues...
@ef4 Some questions about the suggested API: - Do we still want to support the "old" API or deprecate it? - What should the default behavior be if `toPublicPath` isn't...
@deanylev Could you rebase this on the lastest master changes? I think this is good to go otherwise :tada:
@DirkLachowski The component blueprint lives in the ember-source repo, so a PR would be needed there. Good question though, I think that might be missing from the polaris tracking issue....
So skimming through the comments, the remaining blockers are: - remove the flag, we don't need one - update the eslint config so it uses overrides for everything Anything else?...
Ah, I think that's unrelated to this change. That version of `@warp-drive/core-types` doesn't actually exist, so it was wrong in the blueprint. Maybe I need to rebase, I thought that...
It seems it was fixed on "release" not on "master": https://github.com/ember-cli/ember-cli/blob/f1008176dcdde66c4225a21dd4dd5a715fd9ebd4/blueprints/app/files/package.json#L57 I'm not sure what the branching strategy is here, do those changes get merged back to master eventually or...
Closing since a similar change has already been made: https://github.com/ember-cli/ember-cli/commit/ae8f0e34cf0ce807c7ef757238b61fb36bdfe838
Hmm, I think CI isn't using the pnpm patch. It does seem to work locally, so not sure what I did wrong. :thinking: Edit: Ah no, I forgot about the...
> Do you have a pr for the test-helpers as well? ~~No, what test-helpers do you mean?~~ Sorry, It seems I'm a bit slow after a 2 week holiday :sweat_smile:...