Rik Smale

Results 439 comments of Rik Smale

It should only validate mobile phone numbers, but I know that there is some improvement to be done on that front. See also #2124 Outsourcing has not been discussed recently...

This is desired behaviour atm, see also https://github.com/validatorjs/validator.js/pull/1753#issuecomment-933376785 The option `disallow_auth` is provided for this usecase

Thanks for the extensive response, I've reopened the issue so we can take another look at it

Yeah, the dependencies could use some updating. I think the easiest way to solve this one however is to update the following line to get `rollup@^0.60.0`; https://github.com/validatorjs/validator.js/blob/531dc7f1f75613bec75c6d888b46480455e78dc7/package.json#L52 According to semver...

That will install v2 of rollup which does not support Node 6 and does not work with our current config (v0.48 had some breaking changes I believe so that's why...

I would retire anything under Node 18 for the next major release since those are not supported anymore. If people want we can still support Node 1 but that version...

Just fyi; This is the basis of the validator: https://gist.github.com/hagemann/382adfc57adbd5af078dc93feef01fe1 In my opinion any changes to `isSlug` should still conform to that gist. I'll check later if that's the case....

Closing this in favour of https://github.com/validatorjs/validator.js/pull/2453

When building babel does give a warning; ``` Using named and default exports together. Consumers of your bundle will have to use validator['default'] to access the default export, which may...

Might just be a Babel thing. I know there is an outdated PR from one of the maintainers that tried to overhaul the config (also because we're on old versions...