validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

[Varnika|Yashna] Fix. IPv6 format is fixed

Open VarnikaB opened this issue 3 years ago • 4 comments

Fixed the invalid IPv6 address format:

  • BC:e4d5:c:e7b9::%40i0nccymtl9cwfKo.5vaeXLSGRMe:EDh2qs5wkhnPws5xQKqafjfAMm6wGFCJ.bVFsZfb
  • 1dC:0DF8:62D:3AC::%KTatXocjaFVioS0RTNQl4mA.V151o0RSy.JIu-D-D8.d3171ZWsSJ7PK4YjkJCRN0F as invalid

Checklist

  • [x] PR contains only changes related; no stray files, etc.
  • [x] README updated (where applicable)
  • [x] Tests written (where applicable)

"fixes https://github.com/validatorjs/validator.js/issues/2039"

VarnikaB avatar Oct 20 '22 10:10 VarnikaB

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (531dc7f) to head (36b555c). Report is 145 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2083   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 20 '22 10:10 codecov[bot]

I have added the test cases

VarnikaB avatar Oct 24 '22 02:10 VarnikaB

I have added the test cases could you please approve it soon.

VarnikaB avatar Oct 28 '22 03:10 VarnikaB

Can fix the merge conflict, other than that, LGTM. Thanks for your contrib!

profnandaa avatar Apr 25 '24 10:04 profnandaa

Closing this in favour of https://github.com/validatorjs/validator.js/pull/2453

WikiRik avatar Mar 27 '25 19:03 WikiRik