Rik Smale

Results 453 comments of Rik Smale

ISO 8601 is indeed a large spec with various features, that might not fit in a single validator. Can you elaborate a bit on why you would want to validate...

Go for it! Looking forward to the PR

I seemed to have missed the PR being opened, I will take a look at it. I do not have the rights to get it merged or anything so I...

I'm closing this in favour of #14294 As was mentioned there by one of the maintainers; > Unfortunately `sync({ alter })` has a large number of bugs, but fixing them...

@wd-alejandroescobedogarcia thanks for the reminder. This is definitely something we can review. On the relation to the docs, if you update the FindByPkOptions type that should be enough (consider this...

Additionally; considering the size of the method it might be worth it to see if you can move it to the [model-typescript.ts](https://github.com/sequelize/sequelize/blob/main/packages/core/src/model-typescript.ts) class. And preferably also use TypeScript for the...

Thanks for this PR! Due to the summer period and other stuff it might take a while before we can really review this, but we do have this on our...

@cjbj @hjamil-24 that is fair, this has been open for long enough. Would it be possible to rebase this by Friday early afternoon GMT? Then I will block in my...

@hjamil-24 Thanks for the quick response in resolving the merge conflicts! I see that a few comments of @ephys are still open. Could you take a look at those as...

Thanks for resolving so many of the comments already. Let me know when I can do another round of reviews