isURL return true for e-mail

[mjancarik]

Describe the bug Hi,

What is the correct behaviour for isURL function when I give e-mail address? I would expect that return false.

Examples An example from the Node REPL:

Welcome to Node.js v14.16.0.
Type ".help" for more information.
> var validator = require('validator');
undefined
> validator.isURL('[email protected]');
true
> 

Additional context Validator.js version: 13.6.0 Node.js version: 14.16.0 OS platform: macOS

[brybrophy]

I was going to submit a PR to fix this, but then I saw these tests... https://github.com/validatorjs/validator.js/blob/907bb07b8d6be7d159791645960eb5f5017a99b6/test/validators.js#L672-L688

It seems that you can set the disallow_auth option to true and it will fail validation on an email.

[mjancarik]

Hi,

Thank you. I will try it. I would expect default behaviour with disallow_auth to true.

[raghavbk]

@ezkemboi can i work on this issue

[ezkemboi]

@raghavbk if you have a PR, please do it and we will review it. Thanks.

[Jassi10000-zz]

@mjancarik Buddy can you tell one thing

[email protected] : This will treated as an email due to the presence of " @ " in it , so I think its bound to return true to this

[ffxsam]

In no way is an email address a URL, as someone claimed in an issue.

mailto:[email protected] is a URL/URI, but [email protected] is not. This should be considered a bug.

[Yuniac]

Well, till someone figure out which way is the correct way, doing this works for everyone else:

validator.isURL('[email protected]', { disallow_auth: true }); // false

[WikiRik]

This is desired behaviour atm, see also https://github.com/validatorjs/validator.js/pull/1753#issuecomment-933376785 The option disallow_auth is provided for this usecase

[ffxsam]

The maintainers are obviously free to do what they want, but anyone arguing that [email protected] is a URL is flat-out wrong. It's not something subjective that's up for debate. I can cite evidence:

https://datatracker.ietf.org/doc/html/rfc3986#section-1.1.3

A URI can be further classified as a locator, a name, or both. The term "Uniform Resource Locator" (URL) refers to the subset of URIs that, in addition to identifying a resource, provide a means of locating the resource by describing its primary access mechanism (e.g., its network "location").

URI/URL examples: https://datatracker.ietf.org/doc/html/rfc3986#section-1.1.2

The RFC spec says "Each URI begins with a scheme name" and provides another clear example:

   The following are two example URIs and their component parts:

         foo://example.com:8042/over/there?name=ferret#nose
         \_/   \______________/\_________/ \_________/ \__/
          |           |            |            |        |
       scheme     authority       path        query   fragment
          |   _____________________|__
         / \ /                        \
         urn:example:animal:ferret:nose

Sorry to be pedantic, but if we're going to quote someone who claims that [email protected] is a URL "per spec," I think it needs to be called out.

I'm open to being challenged if someone can provide authoritative sources.

[WikiRik]

Thanks for the extensive response, I've reopened the issue so we can take another look at it

[ffxsam]

@WikiRik I appreciate being open to it! If there's no room for pedantry in engineering, then it ain't engineering. 😝