Rik Smale

Results 436 comments of Rik Smale

Undefined sounds good, feel free to open the PR

Can you update to the latest release first (v6.31.0) to see if that resolves this issue?

I agree with @rubiin, `isEmail` should only validate valid emails. Your 2-step validation seems like a reasonable workaround to me.

> But shouldn't the rules have stayed the same, if this is only about updating the tooling versions? Not 100% sure, but default configuration can change over minor versions and...

How would this close the associated issue? The peer dependency versions are still conflicting until we update rollup

Let's revisit this after we've merged #2401

Various `isEmoji` PRs have been opened already, please look at them first. I think the most recent attempt is https://github.com/validatorjs/validator.js/pull/2015 which can benefit from reviews

What might be a better approach is to build in Node 18 (latest LTS), upload the resulting artifact and download that to be used in the other Node versions. That...

This relates to the initial attempt at updating our build tooling as well, and comments/references mentioned in there; https://github.com/validatorjs/validator.js/pull/1869