validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

build: move from npm to pnpm

Open rubiin opened this issue 1 year ago • 3 comments

This pr changes the package manager used from npm to pnpm along with on CI also closes https://github.com/validatorjs/validator.js/issues/2123

Checklist

  • [x] PR contains only changes related; no stray files, etc.
  • [ ] README updated (where applicable)
  • [ ] Tests written (where applicable)
  • [ ] References provided in PR (where applicable)

rubiin avatar May 10 '24 09:05 rubiin

How would this close the associated issue? The peer dependency versions are still conflicting until we update rollup

WikiRik avatar May 10 '24 14:05 WikiRik

About that , pnpm doesnt have that peer dep issue when you run pnpm install. I am hoping to update the deps too but the browser stuff is failing

rubiin avatar May 10 '24 14:05 rubiin

Let's revisit this after we've merged #2401

WikiRik avatar Jun 05 '24 07:06 WikiRik