validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

fix: update all tooling

Open rubiin opened this issue 1 year ago • 4 comments

Updates all tools (expect mocha and nyc) Also has the files linted (was not linted before thus many file changes )

Checklist

  • [x] PR contains only changes related; no stray files, etc.
  • [ ] README updated (where applicable)
  • [ ] Tests written (where applicable)
  • [ ] References provided in PR (where applicable)

rubiin avatar May 10 '24 15:05 rubiin

I think this fixes things @profnandaa . We can do a beta release for this

rubiin avatar May 10 '24 15:05 rubiin

just a quick observation: the biggest chunk of changes here seem to be style changes -> is there a reason for that? I assume it has to do with linting? But shouldn't the rules have stayed the same, if this is only about updating the tooling versions?

pano9000 avatar Aug 25 '24 14:08 pano9000

just a quick observation: the biggest chunk of changes here seem to be style changes -> is there a reason for that? I assume it has to do with linting? But shouldn't the rules have stayed the same, if this is only about updating the tooling versions?

I could reroll the style changes but those are from eslint fix.

rubiin avatar Aug 25 '24 14:08 rubiin

But shouldn't the rules have stayed the same, if this is only about updating the tooling versions?

Not 100% sure, but default configuration can change over minor versions and it might be due to a case that wasn't discovered in earlier versions but is now. If we want to not have those changes we can update the configuration manually

WikiRik avatar Aug 25 '24 15:08 WikiRik