Vincent Langlet

Results 395 comments of Vincent Langlet

I need to use both https://github.com/sonata-project/SonataAdminBundle/pull/7838 and https://github.com/sonata-project/form-extensions/pull/335 @jordisala1991 ?

> So, I would like to do it, but not sure if it is a great idea right now. Maybe we shoul do a two step process. First cleanup javascript...

> Yes, the normal usage it would still be covered. But if someone wants to compile its own js using our sources it will be a bc break (we might...

> One questions about it. Should we support both giving strings and DateTimes? > With the current implementation, both options are compatible, but you can't mix datetimes and strings in...

> It is still used on PageBundle and MediaBundle to validate medias and pages. So probably not that easy to deprecate. I didnt take a look but cant we just...

> I remove the milestone since it won't be done for 2.0, it requires changes on another bundles that are already released (MediaBundle) Can't we remove the usage in a...

I see two solutions: - Moving the DateTimeType to SonataAdmin. - Adding the JS/CSS to the form-extension library. I prefer the second solution ; do you think it's possible ?

> Make this library agnostic of the css/js part, and have something on AdminBundle that overrides it to show a pretty date picker I don't see how a `DatePickerType` will...

> We are super open to integrating Psalm in our codebase indeed: not only does it help our users catching bugs without installing an extra package, it helps us catch...