Max Gautier
Max Gautier
Can you explain the benefits of those changes ?
If this still needed after https://github.com/kubernetes-sigs/kubespray/pull/11953 ?
/lifecycle frozen /triage accepted
Yes, this is one of the good examples of the technical debt in the `download` role. A refactor which should improve things is on my todo list, but there is...
Could you also add the skipPhases in the UpgradeConfig ? It's currently https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta4/#kubeadm-k8s-io-v1beta4-UpgradeApplyConfiguration but it will be in the future. \+ a TODO on the skip-phase cli option to remove...
This looks fine :+1:, thanks ! Please squash into a single commit and we'll be good to merge. /approve
Yeah, good point /cherrypick release-2.28
/lgtm Thanks for the fix !