Max Gautier

Results 826 comments of Max Gautier

I guess if we somehow wants to override the kubeadm version ? But since we have a check that fail if it's different from kube_version, we should probably just drop...

I suggest checking the RELEASE.md file to see how you can draft a release proposal, + using the tasklist feature of github for things that are missing (open PR,issues, PR...

I'm not completely sure crun is not used by anything but crio. In particular we have tasks to create RuntimeClass using crun (roles/kubernetes-apps/container_runtimes/crun). Since container runtimes can co-exists (unlike container...

this looks like #10436 which was recently fixed. /close feel free to reopen if it's in fact a different bug

> Solution provided by @jonny-ervine does the trick, but deployment does not work fully with the defaults(and personally took some time to figure it out) Perhaps ipip should be the...

What happens exactly if the var is not set ? We try to avoid `is defined` check and have all variables in roles defaults as much as practically possible.

Yes, just default to the subnet-it and put it in the same cond block. > Note that the template roles/kubernetes-apps/external_cloud_controller/openstack/templates/external-openstack-cloud-config.j2 has already a ton of is defined. Maybe a global...