Max Gautier
Max Gautier
> 1. This sounds kinda risky, vast majority install ansible via ansible and not ansible-core, many people wont install dependencies manually from galaxy.yaml IMO I don't know why, I was...
>Please re-test, The CI automatically re triggered each time you push, thankfully we don't have to retest manually ^. Looks like netaddr is required as well for the IP manipulation...
That's because the testcase file has been renamed in the Ubuntu 24 PR. Rebasing should fix it
Please squash your commits into one, there is no need for 8 commits for that kind of cleanup.
Check #11211 it's a bit broken right now but we should sort this out shortly.
I restarted the tests, that was a flake. /lgtm /assign @mzaian @ant31
We should frankly delete the inventory_builder script, it does not offer much compared to simply edit an ini-style Ansible inventory (which IMO are easier to read). But no, the docker...
I think you can already do `deploy_container_engine: false` to not deploy docker (or anything else), is that not appropriate here for some reason ?
> This is suitable for a scenario where docker is already installed on a node and there are already business applications running on top of docker, and I want to...
Actually, this check does not really make sense: We allow to customize `kubeadm_version` (it's defined in roles/kubespray-defaults/main/download.yml). If we don't want to do that (which seems the intention of that...