Max Gautier

Results 826 comments of Max Gautier

You need to rebase your branch, the CI setup has changed and the docker-machine executor is no longer available on the CI cluster

Oh you pushed on the master branch of your fork, I see what kind of problems you could have. You could do somehting like that ```shell $ git fetch #...

While it's a bit nicer, it's a breaking change and I'm not convinced this is worth it...

/approve Can you squash your commits ? The last two fixes the first, so they should be one (ok-to-test is merely to allow CI to run)

Could you edit your commit message (or alternatively add a comment in the code) to explain why the end result is functionally identical ? While I think I get the...

@clwluvw nudge on this, thanks :+1: