Max Gautier
Max Gautier
This looks good but you'll need to rebase, there has been ansible and CI changes.
Sorry I missed something on my previous review: by default I meant put the variable in the role defaults, not use the default filter. That way the defaults acts as...
Yep, exactly, thanks ! /lgtm /approve
It this still the case in master with #12015 in ?
So, yes, I presume ?
I believe this is another case of #11552 (=> modification are not taken into account, but current settings remains). Could anyone experiencing the bug confirm ? (that you didn't have...
This should have been fixed by https://github.com/kubernetes-sigs/kubespray/pull/12015, this is a bit strange.
So to recap: - No OIDC on fresh cluster install even with the OIDC kubespray vars - No OIDC on upgrade with the vars, when OIDC was not configured before....
IIRC, v1beta4 introduced an UpgradeConfiguration which has to be used for a number of things, so that's a possible lead.
Since inventory_builder has been removed in #11748 , closing.