Max Gautier
Max Gautier
You should pull out the image list generation from the "image loop" (download_container.yml is repeatedly included in download/main.yml) since there is really no reason we should do that. There is...
/reopen
Avoid using `default` if possible, rather define the variable in the defaults folder of the role. (Where you can also put comments for documentation). Also, seems the effects are the...
/lgtm /assign @ant31
@tu1h you're missing an approval, not a review ^^. I'm not an approver for now
/wip Not completely finished yet ^
/retitle WIP: Refactor download role with simpler conditionals
/assign @liupeng0518 @yankay
There is apparently a fork : https://github.com/rajch/weave If it ends up maintained, switching the reference might enough.
I skimmed that issue, but it might indeed. IMO our current variables are not super clear, and don't distinguish clearly between reserving resources (aka, reducing allocatable) and enforcing (add hard...