Urgau

Results 132 comments of Urgau

Yes of course. A Markdown output was in my plans but I never took the time to do it, plus the architecture of the project makes it a bit difficult...

> Fundamentally this LGTM. If we absolutely want to make sure that the AVX512 path is tested then we may want to run the test under `qemu-x86_64`. Is is required...

> Wait, never mind. This one failed in CI and wasn't fixed. > > I wonder how it got back into the bors queue? Not the first time. It sometimes...

I tried pretty hard to reproduce the crash (with/without qemu, with/without mold, with/without native libs, ...) but I'm still unable to reproduce it. It always successfully pass. I'm not sure...

> Can you reproduce the issue with `./x.py test src/test/ui --target=i586-unknown-linux-gnu`? Seems like yes, which does not really make sense to me. Anyway this is progress. I will try to...

I've been unable to find the exact cause of the problem but since [`src/test/ui/see2.rs`](https://github.com/rust-lang/rust/blob/c493bae0d8efd75723460ce5c371f726efa93f15/src/test/ui/sse2.rs#L9-L17) manually disable any sse2 test on `i586-unknown-linux-gnu`, I've done the same and added the same check....

I also encounter this problem on aspnet core 3.1. The problem seems to be due to the use of **PathAndQuery** in [RedirectToProfile](https://github.com/dotnet/aspnetcore/blob/636ff94d04e6872ec8b95e740f2df9cb52384ae1/src/Components/WebAssembly/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.cs#L361) and [RedirectToRegister](https://github.com/dotnet/aspnetcore/blob/636ff94d04e6872ec8b95e740f2df9cb52384ae1/src/Components/WebAssembly/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.cs#L353-L359) which doesn't include the base url.

Hello, @javiercn sorry to ping you but since you wrote the code in question, you may confirm that this is indeed a bug and that it is indeed in [RedirectToProfile](https://github.com/dotnet/aspnetcore/blob/636ff94d04e6872ec8b95e740f2df9cb52384ae1/src/Components/WebAssembly/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.cs#L361)...

What about we keep `path` at least until https://github.com/rust-lang/rust/issues/99513 is resolved and after it is resolved we see if it's still useful to keep it. Would this address your concern...

> Two Comments: > > 1. I Don't think the format churn is worth it, as it's just renames. I'm tracking all the renames I want to do in [Rustdoc-Json:...