Urgau

Results 89 comments of Urgau
trafficstars

Status update, as of `2024-01-18`. Two new PRs have been merged, #119473 and #119930. They come from a feedback from Cargo (thanks `@epage`), where we realised that empty `values()` were...

Status update, as of `2024-02-10`: 1. A Crater run has been done in #120701, the full analysis report can be found [here](https://github.com/rust-lang/rust/issues/120701#issuecomment-1937010106). The here is (very) condensed summary: > After...

@ojeda Thanks you for testing the future. > * The kernel has ~20k (yes, kilo!) configuration options. For a quick test on this feature, I transformed the ~3k `--cfg` flags...

> Thanks! However, I wouldn't write the list to disk -- I don't think it is useful to see the list, and we would need to ignore those files in...

Yes, it should work. We do (in `rustc`) special case const-anon to not lint, given the widespread usage of that pattern.

All the review comments have been addressed or have been replied to. @rustbot ready

@estebank could you give this PR another review.

With the release of rust-lang/cargo#13913 (in nightly-2024-05-19), Cargo has gain the ability to declare `--check-cfg` args directly in the `[lints]` table with [`[lints.rust.unexpected_cfgs.check-cfg]`](https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html#check-cfg-in-lintsrust-table)[^1]: `Cargo.toml`: ```toml [lints.rust] unexpected_cfgs = { level...

There is no reason it wouldn't. The feature is only active with Rust 1.80. And while `[lints.rust.unexpected_cfgs.check-cfg]` produces a unused warning for Rust 1.78 and below, it is only present...

> Do you know why all these lints are prefixed by `Builtin`? Aren't all the lints in the compiler built-in by definition? It's probably a prefix for the lints defined...