Urgau comments

Results 94 comments of


                                            Urgau

trafficstars

Add lint against function pointer comparisons

> If it's not too much work, could we do a crater run here to find out what kind of places are using this kind of comparison in the wild?...

Add lint against function pointer comparisons

# Crater Analysis Result ## Summary | Crate | True-positive | Not duplicated | In PartialEq | Comments | |------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------|----------------|--------------|-------------------------------------------------------------| | [AntidermisMC.rlox](https://github.com/AntidermisMC/rlox/tree/3b8e0bb4d5f6911b058aed4b49029233130b745e) *[logs](https://crater-reports.s3.amazonaws.com/pr-118833-1/try%2329596578cb5035fa2b7ac7fbdfea23fab38836e7/gh/AntidermisMC.rlox/log.txt)* | ? | | ✓ | VM...

`unfulfilled_lint_expectations` emitted upon a correct `#[expect(clippy::enum_glob_use)]`

`--all-targets` enables `--tests` which enables the test harness generation (`rustc --test`) which some lint are gated against, which means that they don't emit the lint which triggers the `unfulfilled_lint_expectations` lint...

Rust 1.80 upcoming warning: unexpected `cfg` condition name: `coverage_nightly`

Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19), Cargo has now gain the ability to declare `--check-cfg` args directly inside the `[lints]` table with [`[lints.rust.unexpected_cfgs.check-cfg]`](https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html#check-cfg-in-lintsrust-table)[^1]: `Cargo.toml`: ```toml [lints.rust] unexpected_cfgs...