Urgau

Results 77 comments of Urgau

@nbdd0121 Look at https://github.com/rust-lang/rust/pull/93564 which was a more targeted fix. Maybe it could be reopened ? EDIT: Looking into it right now.

@nbdd0121 I've reopened https://github.com/rust-lang/rust/pull/93564 as https://github.com/rust-lang/rust/pull/97559. I've confirmed that with the PR the regression is fixed and hopefully the perf regression of the PR is also fixed.

https://github.com/rust-lang/rust/issues/100711 seems that it might also to be related (also does some networking stuff) and have a much simpler MCVE: ```rust use std::net::ToSocketAddrs; pub fn main() { println!("before"); let _...

To speed up the review process of this PR, can you add to your initial message the answers to the [Tier 3 Target Tier Policy](https://doc.rust-lang.org/nightly/rustc/target-tier-policy.html#tier-3-target-policy). Example here https://github.com/rust-lang/rust/pull/94872#issue-1167108356. As well...

I investigated the build issue and contrary to what I originally though this is a legitimate build error because `bootstrap` is never set for proc-macro crates. The reason why is...

> Thanks @jplatte and @Urgau for the help. I have allowed lint for that crate for now, which can go to master until a better approach is found. This is...

Hum... okay! I didn't see that coming. Sorry for the later comment and thanks for the future PR.

> As for overriding... the docs are clear that `eq` is a required method and `ne` is a provided method. Is a warning really necessary? This could change if [`#[rustc_must_implement_one_of(eq,...

> @Urgau: This feature doesn't work how I expected. Here I've implemented both `eq` and `neq` and with a nightly compiler I don't get any warnings: I'm not the one...

Yeah, sorry for that. I have been quite bussy lately and didn't catch up with the latest modifications. As for testing on `rd` it should be possible if you use...