Try
Try
Hi @lmichaelis ! Fix works only partially: visual is still null with `zenkit::VMover` and some other objects. Probably related to objects with `has_visual_object==false`
> Are there any other concerns with the new version? If not, I'll finally do the 1.3 release :) Building now with `ZK_ENABLE_DEPRECATION=ON` - still some stuff to cleanup, will...
1. ```c++ C:/Programming/OpenGothic/lib/ZenKit/include/zenkit/ModelAnimation.hh:163:84: note: declared here 163 | ZKREM("renamed to Animation::sample_position_scale") float sample_position_scalar {}; | ^~~~~~~~~~~~~~~~~~~~~~ C:/Programming/OpenGothic/game/graphics/mesh/animation.cpp: In constructor 'Animation::Sequence::Sequence(const zenkit::MdsAnimation&, std::string_view)': C:/Programming/OpenGothic/game/graphics/mesh/animation.cpp:197:26: note: synthesized method 'zenkit::ModelAnimation::ModelAnimation()' first required here...
> Can you point out an instance in which this causes problems? Tested vanilla G2-notr, via: ``` auto sz = _m_stack_ptr; sz += (sym->has_return() ? 1 : 0); sz -=...
> Yes I know these cases exist, but where does extra data on the stack cause actual problems? Lack of data - problem in CoM. Getting `"popping instance from empty...
> proper parsing routine Not for this: ZUNIONUTILS.DLL :)
> Could you send over the VDF file that caused the error so I can investigate? Unfortunately can't. This bug was reported on worldofplayer.ru forum, so don't have the file...
Bump: got the Union.vdf file. [Union.zip](https://github.com/lmichaelis/phoenix/files/10717326/Union.zip)
> Btw, I apologize for my absence this past week, I've been ill. Welcome back :D > When extracted as-is, all content is just random bytes and no structure can...
Tested today on latest `phoenix` commit(36d8d5f5562f2126fdab7d7a8a5aee362a432e42) in master branch: Load fine without Union.vdf, but with Union.vdf, game throws exception upon game loading: ``` loading error: buffer underflow at byte 6...