Rich Trott

Results 501 comments of Rich Trott

I've unarchived this repo so I can close all PRs and issues before re-archiving.

I've unarchived this repo so I can close all PRs and issues before re-archiving.

Still happening but differently/only with the stuff at the end of the header. Note the dark mode/light mode switcher and the translation picker in this screenshot:

I'm in favor of whatever is easiest/quickest to do right now in terms of getting the merge/migration/whatever of nodejs.dev and nodejs.org completed unless doing so makes it harder to do...

I'm pretty sure the problem is this code which sets `aria-selected` regardless of whether the tab title has `role=button` or not. (This is in `activateTab()`. There is a similar issue...

Looks like the tests are passing now and this can land?

> It failed on Windows. Maybe we can re-add it with skipping Windows then?

> Sure, here's a full CI job: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/258/ Looks like it's still failing. Oh well. Back to draft mode until someone wants to look into it or enough time has...

Oh well, still failing. Back to draft mode.