citgm icon indicating copy to clipboard operation
citgm copied to clipboard

lookup: re-add winston

Open Trott opened this issue 2 years ago • 7 comments

Checklist
  • [x] npm test passes
  • [x] contribution guidelines followed here

Trott avatar Sep 24 '23 22:09 Trott

Codecov Report

Patch and project coverage have no change.

Comparison is base (f15c9a2) 96.44% compared to head (bc73fe5) 96.44%. Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #983   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          28       28           
  Lines        2139     2139           
=======================================
  Hits         2063     2063           
  Misses         76       76           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 24 '23 22:09 codecov-commenter

Looks like the tests are passing now and this can land?

Trott avatar Aug 01 '24 20:08 Trott

https://github.com/nodejs/citgm/actions/runs/10236928954

targos avatar Aug 04 '24 14:08 targos

It failed on Windows.

targos avatar Aug 05 '24 05:08 targos

It failed on Windows.

Maybe we can re-add it with skipping Windows then?

Trott avatar Aug 06 '24 23:08 Trott

Sure, here's a full CI job: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/258/

targos avatar Aug 07 '24 06:08 targos

Sure, here's a full CI job: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/258/

Looks like it's still failing. Oh well. Back to draft mode until someone wants to look into it or enough time has passed that it makes sense to try again.

Trott avatar Aug 07 '24 15:08 Trott