citgm icon indicating copy to clipboard operation
citgm copied to clipboard

lookup: re-add tough-cookie

Open Trott opened this issue 2 years ago • 5 comments

Checklist
  • [x] npm test passes
  • [x] contribution guidelines followed here

Trott avatar Sep 24 '23 22:09 Trott

Codecov Report

Patch and project coverage have no change.

Comparison is base (f15c9a2) 96.44% compared to head (95fb9c5) 96.44%. Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          28       28           
  Lines        2139     2139           
=======================================
  Hits         2063     2063           
  Misses         76       76           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 24 '23 22:09 codecov-commenter

https://github.com/nodejs/citgm/actions/runs/10236925220

targos avatar Aug 04 '24 14:08 targos

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/257/

targos avatar Aug 05 '24 05:08 targos

Oh well, still failing. Back to draft mode.

Trott avatar Aug 05 '24 17:08 Trott

Sample error:

 added 246 packages in 11s
 > [email protected] test
 > vows test/*_test.js && npm run eslint
                  
    
    
     util usage in Cookie 
        custom inspect for Cookie still works 
                 
         actual expected 
          
         Cookie="a=1; Domain=example.com; Path=/; hostOnly=?; aAge=?; cAge=1ms0ms" 
          // /home/iojs/tmp/citgm_tmp/a1c3705b-8fec-4e63-a472-a173b880f632/tough-cookie/node_modules/vows/lib/assert/macros.js:14 
    Broken  826 honored  1 broken (6.895s) 
   
 (node:2510650) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
 (Use `node --trace-deprecation ...` to show where the warning was created)

Trott avatar Aug 05 '24 17:08 Trott