Rich Trott

Based on https://github.com/nodejs/citgm/issues/997, maybe it's time to land this? @UlisesGascon If you want to rebase this, please do! (Otherwise, I'll do it at some point and force-push it to your...

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3261/

The tests that set `LC_ALL` to `'sk'` all fail because (I think) that locale is not on our Jenkins servers. ``` sh: warning: setlocale: LC_ALL: cannot change locale (sk): No...

> I regret that I haven't looked closer yet into npm's failures in `citgm`, so I'm not sure if this is possible. I'm not sure, but it might have only...

For comparison, running CITGM on npm using CITGM@8. If this passes, then we'll bisect and figure out what changed in CITGM to cause the failures: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3262/

> For comparison, running CITGM on npm using CITGM@8. If this passes, then we'll bisect and figure out what changed in CITGM to cause the failures: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3262/ CITGM@8 fails too,...

On the one hand, 1 million+ weekly downloads says "yes". On the other hand, no commits or releases in 5 years suggests "maybe not" because it suggests that we might...

@nodejs/documentation @rubys

The failure of `test-buffer-alloc` on Travis was unrelated to this change and was fixed in another commit on master already. (That one was my fault. Sorry!) The other stuff here...

(To fix your local failures, you probably just need to rebase against current upstream/master. If that doesn't do it, the next most obvious likely problem is a bug in macOS...