TomWerner
TomWerner
The relevant TODO: https://github.com/C7-Game/Prototype/blob/8b7643a1641ac43ca25ec0d6b1efc09df16c4d78/C7Engine/AI/UnitAI/SettlerLocationAI.cs#L48 This is done mostly correctly in the map generation logic, where there's a [TODO](https://github.com/C7-Game/Prototype/blob/8b7643a1641ac43ca25ec0d6b1efc09df16c4d78/C7Engine/MapGenerator.cs#L1457) to unify the logic.
We have a [trade factor](https://github.com/C7-Game/Prototype/blob/8b7643a1641ac43ca25ec0d6b1efc09df16c4d78/C7Engine/AI/PlayerAI.cs#L395-L399) for AI and human trades, but it is hardcoded. We should be using the value from the [difficulty](https://github.com/C7-Game/Prototype/blob/8b7643a1641ac43ca25ec0d6b1efc09df16c4d78/C7Engine/C7GameData/Difficulty.cs#L36).
Right now we always use a standard size world, but we have the [buttons](https://github.com/C7-Game/Prototype/blob/8b7643a1641ac43ca25ec0d6b1efc09df16c4d78/C7/UIElements/NewGame/WorldSetup.cs#L270-L277) for the other sizes, they're just hidden. We [hardcoded](https://github.com/C7-Game/Prototype/blob/8b7643a1641ac43ca25ec0d6b1efc09df16c4d78/C7/UIElements/NewGame/PlayerSetup.cs#L40) the number of opponents in the player...
Here are the relevant TODOs: - https://github.com/C7-Game/Prototype/blob/8b7643a1641ac43ca25ec0d6b1efc09df16c4d78/C7/UIElements/Advisors/DomesticAdvisor.cs#L162 - https://github.com/C7-Game/Prototype/blob/8b7643a1641ac43ca25ec0d6b1efc09df16c4d78/C7/UIElements/Advisors/DomesticAdvisor.cs#L284 We already track [maintenance costs](https://github.com/C7-Game/Prototype/blob/8b7643a1641ac43ca25ec0d6b1efc09df16c4d78/C7Engine/C7GameData/City.cs#L545), and we can calculate the city-based revenue and tax collector revenue pretty easily from methods in...
I also replaced some hardcoded constants with the relevant rules.
I think this should fix the issue of local files not being found on macs. I used this reference: https://docs.godotengine.org/en/latest/tutorials/io/data_paths.html