Tom Kelly

Results 44 comments of Tom Kelly

@Emiller88 thank you for taking the time to review! It shouldn't be difficult to make the recommended changes. Let me explain a few general points. UniverSC has several advantages over...

I've updated the module. Note that all tests with `PROFILE=docker` now pass successfully. The only module that does not run without errors is universc/mkfastq. As with cellranger/mkfastq (which uses a...

> Only things I still see is whether the testing strategy is going to run the tests twice, and might change the name of the main module. Thanks for checking...

I've run into a similar issue and managed to fix it. The problem is that `preseq` requires a _BED_ file as input. See [here](https://bedtools.readthedocs.io/en/latest/content/tools/bamtobed.html) in the `bedtools` on how to...

I added more specific details to the Japanese versions to clarify that it describes "the process of preparing data for analysis" but I think it's important for non-native speakers to...

> I've looked at the English additions and commented; I've also requested a review from the Japanese team for the rest. Thanks for your prompt feedback! Masami has been alerted...

The following terms have been removed from this PR and moved to #307 for further discussion. All other terms have been reviewed without major issues so I think better to...

@masamiy I think the issue is a mixture of Romaji, Katakana, and Kanji in the terms defined. It's sorting them correctly (as expected for this). I see two solutions: 1....

Regarding the order of the entries, the languages on the [homepage](https://glosario.carpentries.org/) may need to be changed as well (this is done manually as I understand it). Sorry this may need...

I'm not familiar with other styles (except crude 方言) so bear with me. I looked up 体言止め and it seems to be appropriate. +1 for consistency going forward. The question...