azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
[DesktopVirtualization] Stable 2024 04 03 Release
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 206 Errors, 287 Warnings failed [Detail]
| Compared specs (v0.10.8) | new version | base version |
|---|---|---|
| desktopvirtualization.json | 2024-04-03(3461f1d) | 2023-09-05(main) |
| desktopvirtualization.json | 2024-04-03(3461f1d) | 2024-03-06-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 25 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 25 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostManagements/default' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L2581:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostManagements' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L2727:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostManagements/default/initiateSessionHostUpdate' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L2772:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostManagements/default/controlSessionHostUpdate' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L2838:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostManagements/default/operationStatuses/{operationId}' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L2905:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostManagements/default/operationStatuses' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L2950:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostConfigurations/default' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L3037:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostConfigurations' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L3227:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostConfigurations/default/operationStatuses/{operationId}' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L3272:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHostConfigurations/default/operationStatuses' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L3317:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/activeSessionHostConfigurations/default' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L3376:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/activeSessionHostConfigurations' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L3418:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/sessionHosts/{sessionHostName}/retryProvisioning' removed or restructured? Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L3871:5 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'SessionHostManagement' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'SessionHostManagementProperties' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'SessionHostManagementPatch' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'SessionHostManagementPatchProperties' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'HostPoolUpdateConfigurationProperties' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'HostPoolUpdateConfigurationPatchProperties' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'HostPoolControlParameter' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'UpdateSessionHostsRequestBody' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'SessionHostConfiguration' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'SessionHostConfigurationProperties' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'SessionHostConfigurationPatch' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'SessionHostConfigurationPatchProperties' removed or renamed? New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4196:3 Old: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json#L5127:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2024-04 | package-2024-04(3461f1d) | default(main) |
The following errors/warnings exist before current PR submission:
Only 25 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Operations API path must follow the schema provided in the common types. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L50 |
|
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L225 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByWorkspace' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L386 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L386 |
|
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L773 |
|
Properties of a PATCH request body must not be required, property:hour. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1041 |
|
Properties of a PATCH request body must not be required, property:minute. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1041 |
|
Properties of a PATCH request body must not be required, property:hour. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1307 |
|
Properties of a PATCH request body must not be required, property:minute. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1307 |
|
Properties of a PATCH request body must not have default value, property:rampUpStartVMOnConnect. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1307 |
|
Properties of a PATCH request body must not have default value, property:peakStartVMOnConnect. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1307 |
|
Properties of a PATCH request body must not have default value, property:rampDownStartVMOnConnect. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1307 |
|
Properties of a PATCH request body must not have default value, property:offPeakStartVMOnConnect. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1307 |
|
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1618 |
|
The property 'tags' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L2007 |
|
The property 'tags' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L2172 |
|
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L2428 |
|
The path segment resourcegroups should be resourceGroups. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L2989 |
|
The path segment resourcegroups should be resourceGroups. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L3187 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByHostPool' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4141 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L4141 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L6807 |
| :warning: PatchSkuProperty | The patch operation body parameter schema should contain property 'sku'. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L225 |
| :warning: PutInOperationName | 'PUT' operation 'PrivateEndpointConnections_UpdateByWorkspace' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L390 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L473 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Object didn't pass validation for format arm-id: /subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourcegroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostpool1/expandMsixImage Url: common-types/resource-management/v5/types.json#L14:15 ExampleUrl: stable/2024-04-03/examples/MsixImage_Expand_Post.json#L17:19 |
|
Object didn't pass validation for format arm-id: /subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourcegroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostpools/hostpool1/expandmsiximage Url: common-types/resource-management/v5/types.json#L14:15 ExampleUrl: stable/2024-04-03/examples/MsixImage_Expand_Post.json#L47:19 |
|
Object didn't pass validation for format arm-id: /subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourcegroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostpool1/expandMsixImage Url: common-types/resource-management/v5/types.json#L14:15 ExampleUrl: stable/2024-04-03/examples/MsixImage_Expand_Post.json#L17:19 |
|
Object didn't pass validation for format arm-id: /subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourcegroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostpools/hostpool1/expandmsiximage Url: common-types/resource-management/v5/types.json#L14:15 ExampleUrl: stable/2024-04-03/examples/MsixImage_Expand_Post.json#L47:19 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=429139&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded in generating from 69aa2f9b3731f75f8adb02183016eb8f6f951556. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.DesktopVirtualization [Preview SDK Changes]- Azure.ResourceManager.DesktopVirtualization.1.3.0-alpha.20240513.1.nupkg
info [Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning in generating from 69aa2f9b3731f75f8adb02183016eb8f6f951556. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. cmderr [automation_init.sh] cmderr [automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0 cmderr [automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0> cmderr [automation_init.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_init.sh] npm notice command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-desktopvirtualization [Preview SDK Changes] Breaking Change Detected- azure-mgmt-desktopvirtualization-1.0.0b1.zip
- azure_mgmt_desktopvirtualization-1.0.0b1-py3-none-any.whl
info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group AppAttachPackageInfoOperations info [Changelog] - Added operation group AppAttachPackageOperations info [Changelog] - Model ApplicationGroupPatch has a new parameter system_data info [Changelog] - Model ExpandMsixImage has a new parameter certificate_expiry info [Changelog] - Model ExpandMsixImage has a new parameter certificate_name info [Changelog] - Model ExpandMsixImage has a new parameter system_data info [Changelog] - Model HostPool has a new parameter app_attach_package_references info [Changelog] - Model HostPoolPatch has a new parameter system_data info [Changelog] - Model MSIXPackagePatch has a new parameter system_data info [Changelog] - Model PrivateEndpointConnection has a new parameter group_ids info [Changelog] - Model PrivateEndpointConnection has a new parameter system_data info [Changelog] - Model PrivateEndpointConnectionWithSystemData has a new parameter group_ids info [Changelog] - Model PrivateLinkResource has a new parameter system_data info [Changelog] - Model ProxyResource has a new parameter system_data info [Changelog] - Model Resource has a new parameter system_data info [Changelog] - Model ResourceModelWithAllowedPropertySet has a new parameter system_data info [Changelog] - Model ScalingPlanPooledSchedulePatch has a new parameter system_data info [Changelog] - Model SessionHostPatch has a new parameter system_data info [Changelog] - Model StartMenuItem has a new parameter system_data info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Parameter location of model ApplicationGroup is now required info [Changelog] - Parameter location of model HostPool is now required info [Changelog] - Parameter location of model ResourceModelWithAllowedPropertySet is now required info [Changelog] - Parameter location of model ScalingPlan is now required info [Changelog] - Parameter location of model Workspace is now required
Present SDK breaking changes suppressions Parameter location of model ApplicationGroup is now required Parameter location of model HostPool is now required Parameter location of model ResourceModelWithAllowedPropertySet is now required Parameter location of model ScalingPlan is now required Parameter location of model Workspace is now required
Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️✔️Succeeded in generating from 69aa2f9b3731f75f8adb02183016eb8f6f951556. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-desktopvirtualization [Preview SDK Changes]- pom.xml
- azure-resourcemanager-desktopvirtualization-1.2.0-beta.1.jar
- azure-resourcemanager-desktopvirtualization-1.2.0-beta.1-sources.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded in generating from 69aa2f9b3731f75f8adb02183016eb8f6f951556. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/desktopvirtualization/armdesktopvirtualization [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New enum type `AppAttachPackageArchitectures` with values `AppAttachPackageArchitecturesALL`, `AppAttachPackageArchitecturesARM`, `AppAttachPackageArchitecturesARM64`, `AppAttachPackageArchitecturesNeutral`, `AppAttachPackageArchitecturesX64`, `AppAttachPackageArchitecturesX86`, `AppAttachPackageArchitecturesX86A64` info [Changelog] - New enum type `FailHealthCheckOnStagingFailure` with values `FailHealthCheckOnStagingFailureDoNotFail`, `FailHealthCheckOnStagingFailureNeedsAssistance`, `FailHealthCheckOnStagingFailureUnhealthy` info [Changelog] - New enum type `PackageTimestamped` with values `PackageTimestampedNotTimestamped`, `PackageTimestampedTimestamped` info [Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateCanceled`, `ProvisioningStateFailed`, `ProvisioningStateProvisioning`, `ProvisioningStateSucceeded` info [Changelog] - New function `NewAppAttachPackageClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AppAttachPackageClient, error)` info [Changelog] - New function `*AppAttachPackageClient.CreateOrUpdate(context.Context, string, string, AppAttachPackage, *AppAttachPackageClientCreateOrUpdateOptions) (AppAttachPackageClientCreateOrUpdateResponse, error)` info [Changelog] - New function `*AppAttachPackageClient.Delete(context.Context, string, string, *AppAttachPackageClientDeleteOptions) (AppAttachPackageClientDeleteResponse, error)` info [Changelog] - New function `*AppAttachPackageClient.Get(context.Context, string, string, *AppAttachPackageClientGetOptions) (AppAttachPackageClientGetResponse, error)` info [Changelog] - New function `*AppAttachPackageClient.NewListByResourceGroupPager(string, *AppAttachPackageClientListByResourceGroupOptions) *runtime.Pager[AppAttachPackageClientListByResourceGroupResponse]` info [Changelog] - New function `*AppAttachPackageClient.NewListBySubscriptionPager(*AppAttachPackageClientListBySubscriptionOptions) *runtime.Pager[AppAttachPackageClientListBySubscriptionResponse]` info [Changelog] - New function `*AppAttachPackageClient.Update(context.Context, string, string, *AppAttachPackageClientUpdateOptions) (AppAttachPackageClientUpdateResponse, error)` info [Changelog] - New function `NewAppAttachPackageInfoClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AppAttachPackageInfoClient, error)` info [Changelog] - New function `*AppAttachPackageInfoClient.NewImportPager(string, string, ImportPackageInfoRequest, *AppAttachPackageInfoClientImportOptions) *runtime.Pager[AppAttachPackageInfoClientImportResponse]` info [Changelog] - New function `*ClientFactory.NewAppAttachPackageClient() *AppAttachPackageClient` info [Changelog] - New function `*ClientFactory.NewAppAttachPackageInfoClient() *AppAttachPackageInfoClient` info [Changelog] - New struct `AppAttachPackage` info [Changelog] - New struct `AppAttachPackageInfoProperties` info [Changelog] - New struct `AppAttachPackageList` info [Changelog] - New struct `AppAttachPackagePatch` info [Changelog] - New struct `AppAttachPackagePatchProperties` info [Changelog] - New struct `AppAttachPackageProperties` info [Changelog] - New struct `ImportPackageInfoRequest` info [Changelog] - New field `SystemData` in struct `ApplicationGroupPatch` info [Changelog] - New field `SystemData` in struct `ExpandMsixImage` info [Changelog] - New field `CertificateExpiry`, `CertificateName` in struct `ExpandMsixImageProperties` info [Changelog] - New field `SystemData` in struct `HostPoolPatch` info [Changelog] - New field `AppAttachPackageReferences` in struct `HostPoolProperties` info [Changelog] - New field `SystemData` in struct `MSIXPackagePatch` info [Changelog] - New field `SystemData` in struct `PrivateEndpointConnection` info [Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties` info [Changelog] - New field `SystemData` in struct `PrivateLinkResource` info [Changelog] - New field `SystemData` in struct `ScalingPlanPooledSchedulePatch` info [Changelog] - New field `SystemData` in struct `SessionHostPatch` info [Changelog] - New field `SystemData` in struct `StartMenuItem` info [Changelog] info [Changelog] Total 0 breaking change(s), 57 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded in generating from 69aa2f9b3731f75f8adb02183016eb8f6f951556. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-desktopvirtualization [Preview SDK Changes] Breaking Change Detected- azure-arm-desktopvirtualization-2.0.0.tgz
info [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group AppAttachPackageInfo info [Changelog] - Added operation group AppAttachPackageOperations info [Changelog] - Added Interface AppAttachPackage info [Changelog] - Added Interface AppAttachPackageCreateOrUpdateOptionalParams info [Changelog] - Added Interface AppAttachPackageDeleteOptionalParams info [Changelog] - Added Interface AppAttachPackageGetOptionalParams info [Changelog] - Added Interface AppAttachPackageInfoImportNextOptionalParams info [Changelog] - Added Interface AppAttachPackageInfoImportOptionalParams info [Changelog] - Added Interface AppAttachPackageInfoProperties info [Changelog] - Added Interface AppAttachPackageList info [Changelog] - Added Interface AppAttachPackageListByResourceGroupNextOptionalParams info [Changelog] - Added Interface AppAttachPackageListByResourceGroupOptionalParams info [Changelog] - Added Interface AppAttachPackageListBySubscriptionNextOptionalParams info [Changelog] - Added Interface AppAttachPackageListBySubscriptionOptionalParams info [Changelog] - Added Interface AppAttachPackagePatch info [Changelog] - Added Interface AppAttachPackagePatchProperties info [Changelog] - Added Interface AppAttachPackageProperties info [Changelog] - Added Interface AppAttachPackageUpdateOptionalParams info [Changelog] - Added Interface ErrorAdditionalInfo info [Changelog] - Added Interface ErrorDetail info [Changelog] - Added Interface ErrorResponse info [Changelog] - Added Interface ImportPackageInfoRequest info [Changelog] - Added Interface TrackedResource info [Changelog] - Added Type Alias AppAttachPackageArchitectures info [Changelog] - Added Type Alias AppAttachPackageCreateOrUpdateResponse info [Changelog] - Added Type Alias AppAttachPackageGetResponse info [Changelog] - Added Type Alias AppAttachPackageInfoImportNextResponse info [Changelog] - Added Type Alias AppAttachPackageInfoImportResponse info [Changelog] - Added Type Alias AppAttachPackageListByResourceGroupNextResponse info [Changelog] - Added Type Alias AppAttachPackageListByResourceGroupResponse info [Changelog] - Added Type Alias AppAttachPackageListBySubscriptionNextResponse info [Changelog] - Added Type Alias AppAttachPackageListBySubscriptionResponse info [Changelog] - Added Type Alias AppAttachPackageUpdateResponse info [Changelog] - Added Type Alias FailHealthCheckOnStagingFailure info [Changelog] - Added Type Alias PackageTimestamped info [Changelog] - Added Type Alias ProvisioningState info [Changelog] - Interface ExpandMsixImage has a new optional parameter certificateExpiry info [Changelog] - Interface ExpandMsixImage has a new optional parameter certificateName info [Changelog] - Interface HostPool has a new optional parameter appAttachPackageReferences info [Changelog] - Interface PrivateEndpointConnection has a new optional parameter groupIds info [Changelog] - Interface Resource has a new optional parameter systemData info [Changelog] - Added Enum KnownAppAttachPackageArchitectures info [Changelog] - Added Enum KnownFailHealthCheckOnStagingFailure info [Changelog] - Added Enum KnownPackageTimestamped info [Changelog] - Added Enum KnownProvisioningState info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface ApplicationGroup no longer has parameter systemData info [Changelog] - Interface HostPool no longer has parameter systemData info [Changelog] - Interface PrivateEndpointConnectionWithSystemData no longer has parameter systemData info [Changelog] - Interface ResourceModelWithAllowedPropertySet no longer has parameter id info [Changelog] - Interface ResourceModelWithAllowedPropertySet no longer has parameter name info [Changelog] - Interface ResourceModelWithAllowedPropertySet no longer has parameter type info [Changelog] - Interface ScalingPlan no longer has parameter systemData info [Changelog] - Interface ScalingPlanPersonalSchedule no longer has parameter systemData info [Changelog] - Interface Workspace no longer has parameter systemData
Present SDK breaking changes suppressions Interface ApplicationGroup no longer has parameter systemData Interface HostPool no longer has parameter systemData Interface PrivateEndpointConnectionWithSystemData no longer has parameter systemData Interface ResourceModelWithAllowedPropertySet no longer has parameter id Interface ResourceModelWithAllowedPropertySet no longer has parameter name Interface ResourceModelWithAllowedPropertySet no longer has parameter type Interface ScalingPlan no longer has parameter systemData Interface ScalingPlanPersonalSchedule no longer has parameter systemData Interface Workspace no longer has parameter systemData
Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️❌ azure-resource-manager-schemas failed [Detail]
❌Code Generator Failed in generating from 69aa2f9b3731f75f8adb02183016eb8f6f951556. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'... cmderr [initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'... cmderr [initScript.sh] npm notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json cmderr [generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500 cmderr [generateScript.sh] return new TSError(diagnosticText, diagnosticCodes) cmderr [generateScript.sh] ^ cmderr [generateScript.sh] TSError: ⨯ Unable to compile TypeScript: cmderr [generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig. cmderr [generateScript.sh] at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12) cmderr [generateScript.sh] at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19) cmderr [generateScript.sh] at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36) cmderr [generateScript.sh] at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32) cmderr [generateScript.sh] at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43) cmderr [generateScript.sh] at Module._extensions..js (node:internal/modules/cjs/loader:1422:10) cmderr [generateScript.sh] at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12) cmderr [generateScript.sh] at Module.load (node:internal/modules/cjs/loader:1203:32) cmderr [generateScript.sh] at Function.Module._load (node:internal/modules/cjs/loader:1019:12) cmderr [generateScript.sh] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12) error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh warn Skip package processing as generation is failed error ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️️✔️ azure-powershell succeeded [Detail] [Expand]
️✔️Succeeded in generating from 69aa2f9b3731f75f8adb02183016eb8f6f951556. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.desktopvirtualization.DefaultTag [Preview SDK Changes]- Az.DesktopVirtualizationApi.0.1.0.nupkg
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/desktopvirtualization/armdesktopvirtualization | https://apiview.dev/Assemblies/Review/5d2d754fdb64441e992b57b5f303fe2b?revisionId=7ef639fa06c94079b14fabf88d211bb5 |
| Java | azure-resourcemanager-desktopvirtualization | https://apiview.dev/Assemblies/Review/eff8617dd2654aee80849b835d97ce5b?revisionId=a25909f9f72342f6b1c2ba6edc7fe3a1 |
| JavaScript | @azure/arm-desktopvirtualization | https://apiview.dev/Assemblies/Review/a2e675ce22b54e598e9c114e88229134?revisionId=cfd8593c136240adbb3fdf2eab6b74d3 |
| Swagger | Microsoft.DesktopVirtualization | https://apiview.dev/Assemblies/Review/9a75471881634d42b7daa81a823c4b2e?revisionId=ec7dfa7370fd48d8b66839fbbc34c1b7 |
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/Resource"
could you use the newer vesions of the commontypes everywhere in the PR please : v5
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5476 in 7f70719. [](commit_id = 7f70719dd5d802c3b5250b80e08a2c1194095051, deletion_comment = False)
"description": "tags to be updated",
tags for example are already defined in the v5 common types
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5485 in 7f70719. [](commit_id = 7f70719dd5d802c3b5250b80e08a2c1194095051, deletion_comment = False)
"description": "Force flag to delete App Attach package."
[ARMBlockingComment] please do not take query params in the delete payload. ARM will not know to use these for example when doing Resource group delete
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3488 in 7f70719. [](commit_id = 7f70719dd5d802c3b5250b80e08a2c1194095051, deletion_comment = False)
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ResourceModelWithAllowedPropertySet"
v5 everywhere
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5453 in 7f70719. [](commit_id = 7f70719dd5d802c3b5250b80e08a2c1194095051, deletion_comment = False)
"description": "Force flag to delete App Attach package."[ARMBlockingComment] please do not take query params in the delete payload. ARM will not know to use these for example when doing Resource group delete
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3488 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)
We have used force flags for delete throughout our delete endpoints. Is there documentation on why we can't take query params or what the suggested workaround is?
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/Resource"could you use the newer vesions of the commontypes everywhere in the PR please : v5
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5476 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)
Added v5
"description": "tags to be updated",tags for example are already defined in the v5 common types
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5485 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)
Updated to v5, do we need to remove references to tags here?
"description": "tags to be updated",tags for example are already defined in the v5 common types Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5485 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)
Updated to v5, do we need to remove references to tags here?
Are the provided field in v5 Resource enough for your case ? If not, add them in AppAttachPackagePatch. I dont see tags present in "Resource". Please verify if other resource objects can match your case.
"description": "Force flag to delete App Attach package."[ARMBlockingComment] please do not take query params in the delete payload. ARM will not know to use these for example when doing Resource group delete Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3488 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)
We have used force flags for delete throughout our delete endpoints. Is there documentation on why we can't take query params or what the suggested workaround is?
@ramoka178 , please also review this.
"description": "Force flag to delete App Attach package."[ARMBlockingComment] please do not take query params in the delete payload. ARM will not know to use these for example when doing Resource group delete Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3488 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)
We have used force flags for delete throughout our delete endpoints. Is there documentation on why we can't take query params or what the suggested workaround is?
@ramoka178 , please also review this.
appAttachPackages is the new resourcetype getting added in this api version. For the existing APIs, it will be breaking change to alter the API signature. But for the new DELETE APIs, query params are not being allowed.
This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
Learn more at aka.ms/azsdk/pr-arm-review.
For next reviewer: Got an ack for the Delete API having a query param as its an existing pattern for the RP. Waiting on the model validation fix
"description": "Force flag to delete App Attach package."[ARMBlockingComment] please do not take query params in the delete payload. ARM will not know to use these for example when doing Resource group delete Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:3488 in 7f70719. [](commit_id = 7f70719, deletion_comment = False)
We have used force flags for delete throughout our delete endpoints. Is there documentation on why we can't take query params or what the suggested workaround is?
@ramoka178 , please also review this.
appAttachPackages is the new resourcetype getting added in this api version. For the existing APIs, it will be breaking change to alter the API signature. But for the new DELETE APIs, query params are not being allowed.
@ramoka178 said he would be investigating whether this applied to us.
Lets indeed remove the force delete parameter if having it has no benefit.
},
nit - I think systemData is already inherited from v5 trackedResource by default, so you should be able to omit this
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5456 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)
"tags": {
tags are already inherited from v5 trackedResource by default, so you should be able to omit this
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5473 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)
"type": "string"
can add "format": "arm-id"
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5526 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)
"description": "URL of keyvault location to store certificate"
Clarify: is it supposed to be a full path including the certificate name?
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5531 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)
"description": "Schema for patchable fields on an App Attach Package.",
In the context of a PATCH request right. Can we please call it 'updatable' not 'patchable' if that is correct, to avoid confusion with software updates.
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5540 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)
"AppAttachPackagePatchProperties": {
You could consider merging your definitions of AppAttachPackagePatchProperties and AppAttachPackageProperties
and just using "x-ms-mutability" annotations instead
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5539 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)
"AppAttachPackagePatchProperties": {
Or factoring out the hostPoolReferences definition so as to avoid duplication?
In reply to: 2083626271
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5539 in 63d9b3f. [](commit_id = 63d9b3fee8cb05659ca3d19ff3cccaa9a6f5a782, deletion_comment = False)
"AppAttachPackageInfoProperties": {
Are all of the non-readonly AppAttachPackageInfoProperties mutable for PATCH requests? Because I that is what the current model says... If so, great.
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5564 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)
"description": "Schema for Import Package Information properties.",
This description looks probably wrong? Considering you're using it to define the 'AppAttachPackage_Update' request/responses #Resolved
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5565 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)
"description": "Schema for App Attach Package properties.",
The phrasing 'Schema for X' can be a bit confusing in the docs. In the context of docs its usually pretty obvious we're talking about schemas already.... so do you mean it is a schema for a schema?
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5509 in 63d9b3f. [](commit_id = 63d9b3fee8cb05659ca3d19ff3cccaa9a6f5a782, deletion_comment = False)
"ALL"
whats the difference between ALL and Neutral?
Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json:5683 in d04b278. [](commit_id = d04b2788f43132f84e69b43c101da173a4ef6326, deletion_comment = False)