azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
Update Swagger for Static Web Apps database connections
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [x] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [ ] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @joslinmicrosoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| StaticSites.json | 2022-09-01(fe2b320) | 2022-03-01(main) |
️⚠️LintDiff: 16 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2022-09 | package-2022-09(fe2b320) | package-2022-09(release-web-Microsoft.Web-2022-09-01) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| :warning: ListInOperationName | Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L838 |
|
| :warning: RequiredReadOnlySystemData | The response of operation:'StaticSites_GetBuildDatabaseConnection' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L890 |
|
| :warning: RequiredReadOnlySystemData | The response of operation:'StaticSites_CreateOrUpdateBuildDatabaseConnection' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L940 |
|
| :warning: RequiredReadOnlySystemData | The response of operation:'StaticSites_UpdateBuildDatabaseConnection' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L1050 |
|
| :warning: PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'show' in:'StaticSites_GetBuildDatabaseConnectionWithDetails'. Consider updating the operationId Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L1117 |
|
| :warning: ListInOperationName | Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L1329 |
|
| :warning: PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'showdatabaseconnections' in:'StaticSites_GetBuildDatabaseConnectionsWithDetails'. Consider updating the operationId Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L1334 |
|
| :warning: ListInOperationName | Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L2159 |
|
| :warning: RequiredReadOnlySystemData | The response of operation:'StaticSites_GetDatabaseConnection' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L2208 |
|
| :warning: RequiredReadOnlySystemData | The response of operation:'StaticSites_CreateOrUpdateDatabaseConnection' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L2255 |
|
| :warning: RequiredReadOnlySystemData | The response of operation:'StaticSites_UpdateDatabaseConnection' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L2359 |
|
| :warning: PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'show' in:'StaticSites_GetDatabaseConnectionWithDetails'. Consider updating the operationId Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L2423 |
|
| :warning: ListInOperationName | Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L3089 |
|
| :warning: PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'showdatabaseconnections' in:'StaticSites_GetDatabaseConnectionsWithDetails'. Consider updating the operationId Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L3094 |
|
| :warning: AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L4609 |
|
| :warning: AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L4709 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L118 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L161 |
|
An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L200 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L206 |
|
An async PUT operation must return 201. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L234 |
|
Only 201 is the supported response code for PUT async response. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L241 |
|
A 202 response should include an Location response header. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L241 |
|
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L261 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L267 |
|
A 202 response should include an Location response header. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L290 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L313 |
|
The patch operation body parameter schema should contains property 'identity'. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L325 |
|
The patch operation body parameter schema should contains property 'sku'. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L325 |
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L325 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L325 |
|
A 202 response should include an Location response header. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L348 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L375 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L432 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L465 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L488 |
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L514 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L514 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L558 |
|
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L601 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L608 |
|
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L654 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L660 |
|
A 202 response should include an Location response header. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L693 |
|
The path for nested resource doest not meet the valid resource pattern. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L711 |
|
The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.Web/stable/2022-09-01/StaticSites.json#L711 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️✔️azure-sdk-for-js - @azure/arm-appservice - 14.0.0+ Interface AppServiceEnvironmentsListUsagesNextOptionalParams no longer has parameter filter + Interface AppServiceEnvironmentsListWebAppsNextOptionalParams no longer has parameter propertiesToInclude + Interface AppServicePlansListNextOptionalParams no longer has parameter detailed + Interface AppServicePlansListUsagesNextOptionalParams no longer has parameter filter + Interface AppServicePlansListWebAppsNextOptionalParams no longer has parameter filter + Interface AppServicePlansListWebAppsNextOptionalParams no longer has parameter skipToken + Interface AppServicePlansListWebAppsNextOptionalParams no longer has parameter top + Interface CertificatesListNextOptionalParams no longer has parameter filter + Interface ListBillingMetersNextOptionalParams no longer has parameter billingLocation + Interface ListBillingMetersNextOptionalParams no longer has parameter osType + Interface ListCustomHostNameSitesNextOptionalParams no longer has parameter hostname + Interface ListGeoRegionsNextOptionalParams no longer has parameter linuxDynamicWorkersEnabled + Interface ListGeoRegionsNextOptionalParams no longer has parameter linuxWorkersEnabled + Interface ListGeoRegionsNextOptionalParams no longer has parameter sku + Interface ListGeoRegionsNextOptionalParams no longer has parameter xenonWorkersEnabled + Interface ProviderGetAvailableStacksNextOptionalParams no longer has parameter osTypeSelected + Interface ProviderGetAvailableStacksOnPremNextOptionalParams no longer has parameter osTypeSelected + Interface ProviderGetFunctionAppStacksForLocationNextOptionalParams no longer has parameter stackOsType + Interface ProviderGetFunctionAppStacksNextOptionalParams no longer has parameter stackOsType + Interface ProviderGetWebAppStacksForLocationNextOptionalParams no longer has parameter stackOsType + Interface ProviderGetWebAppStacksNextOptionalParams no longer has parameter stackOsType + Interface RecommendationsListHistoryForHostingEnvironmentNextOptionalParams no longer has parameter expiredOnly + Interface RecommendationsListHistoryForHostingEnvironmentNextOptionalParams no longer has parameter filter + Interface RecommendationsListHistoryForWebAppNextOptionalParams no longer has parameter expiredOnly + Interface RecommendationsListHistoryForWebAppNextOptionalParams no longer has parameter filter + Interface RecommendationsListNextOptionalParams no longer has parameter featured + Interface RecommendationsListNextOptionalParams no longer has parameter filter + Interface RecommendationsListRecommendedRulesForHostingEnvironmentNextOptionalParams no longer has parameter featured + Interface RecommendationsListRecommendedRulesForHostingEnvironmentNextOptionalParams no longer has parameter filter + Interface RecommendationsListRecommendedRulesForWebAppNextOptionalParams no longer has parameter featured + Interface RecommendationsListRecommendedRulesForWebAppNextOptionalParams no longer has parameter filter + Interface WebAppsListByResourceGroupNextOptionalParams no longer has parameter includeSlots + Interface WebAppsListPerfMonCountersNextOptionalParams no longer has parameter filter + Interface WebAppsListPerfMonCountersSlotNextOptionalParams no longer has parameter filter + Interface WebAppsListUsagesNextOptionalParams no longer has parameter filter + Interface WebAppsListUsagesSlotNextOptionalParams no longer has parameter filter + Interface WorkflowRunActionsListNextOptionalParams no longer has parameter filter + Interface WorkflowRunActionsListNextOptionalParams no longer has parameter top + Interface WorkflowRunsListNextOptionalParams no longer has parameter filter + Interface WorkflowRunsListNextOptionalParams no longer has parameter top + Interface WorkflowTriggerHistoriesListNextOptionalParams no longer has parameter filter + Interface WorkflowTriggerHistoriesListNextOptionalParams no longer has parameter top + Interface WorkflowTriggersListNextOptionalParams no longer has parameter filter + Interface WorkflowTriggersListNextOptionalParams no longer has parameter top + Interface WorkflowVersionsListNextOptionalParams no longer has parameter top + Removed Enum KnownEnum14 + Removed Enum KnownEnum15 + Removed Enum KnownEnum16 + Removed Enum KnownEnum17 + Removed Enum KnownEnum18 + Removed Enum KnownEnum19 + Removed Enum KnownWorkflowState + Type of parameter osTypeSelected of interface ProviderGetAvailableStacksOnPremOptionalParams is changed from Enum19 to ProviderOsTypeSelected + Type of parameter osTypeSelected of interface ProviderGetAvailableStacksOptionalParams is changed from Enum14 to ProviderOsTypeSelected + Type of parameter stackOsType of interface ProviderGetFunctionAppStacksForLocationOptionalParams is changed from Enum16 to ProviderStackOsType + Type of parameter stackOsType of interface ProviderGetFunctionAppStacksOptionalParams is changed from Enum15 to ProviderStackOsType + Type of parameter stackOsType of interface ProviderGetWebAppStacksForLocationOptionalParams is changed from Enum17 to ProviderStackOsType + Type of parameter stackOsType of interface ProviderGetWebAppStacksOptionalParams is changed from Enum18 to ProviderStackOsType
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed [Logs] Generate from 58a72ad8ff910cd68f59155faf5dcb09e6d03946. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672 cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m 672 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m | [31;1mFailed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] [0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760 cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m 760 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m | [31;1mCannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1mit does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] [0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672 cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m 672 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m | [31;1mFailed to generate sdk artifact cmderr [Invoke-GenerateAndBuildV2.ps1] [0m
❌Azure.ResourceManager.AppService [View full logs] [Preview SDK Changes]info [Changelog]
️❌ azure-sdk-for-python-track2 failed [Detail]
❌Code Generator Failed [Logs] Generate from 58a72ad8ff910cd68f59155faf5dcb09e6d03946. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.5.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice cmdout [automation_generate.sh] [Autorest] File "/home/cloudtest/.autorest/@[email protected]/node_modules/@autorest/python/autorest/codegen/serializers/metadataserializer.py", line 62, in <lambda> cmdout [automation_generate.sh] [Autorest] key=lambda e: "".join(e) # type: ignore cmdout [automation_generate.sh] [Autorest] TypeError: sequence item 1: expected str instance, NoneType found cmdout [automation_generate.sh] [Autorest] fatal | Process() cancelled due to failure cmdout [automation_generate.sh] [Autorest] error | Batch/Error | Failure during batch task - {"tag":"package-2018-02-only"} -- Error: Plugin codegen reported failure. cmdout [automation_generate.sh] [Autorest] error | Error: Plugin codegen reported failure. cmdout [automation_generate.sh] [Autorest] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmdout [automation_generate.sh] [Autorest] File "/home/cloudtest/.autorest/@[email protected]/node_modules/@autorest/python/autorest/codegen/serializers/metadataserializer.py", line 62, in <lambda> cmdout [automation_generate.sh] [Autorest] key=lambda e: "".join(e) # type: ignore cmdout [automation_generate.sh] [Autorest] TypeError: sequence item 1: expected str instance, NoneType found cmdout [automation_generate.sh] [Autorest] fatal | Process() cancelled due to failure cmdout [automation_generate.sh] [Autorest] error | Batch/Error | Failure during batch task - {"tag":"package-2018-02-only"} -- Error: Plugin codegen reported failure. cmdout [automation_generate.sh] [Autorest] error | Error: Plugin codegen reported failure. cmdout [automation_generate.sh] [Autorest] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmdout [automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh warn Skip package processing as generation is failed
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 58a72ad8ff910cd68f59155faf5dcb09e6d03946. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-appservice-generated [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 58a72ad8ff910cd68f59155faf5dcb09e6d03946. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/appservice/armappservice [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New type alias `DefaultAction` with values `DefaultActionAllow`, `DefaultActionDeny` info [Changelog] - New type alias `WorkflowHealthState` with values `WorkflowHealthStateHealthy`, `WorkflowHealthStateNotSpecified`, `WorkflowHealthStateUnhealthy`, `WorkflowHealthStateUnknown` info [Changelog] - New function `*StaticSitesClient.CreateOrUpdateBuildDatabaseConnection(context.Context, string, string, string, string, DatabaseConnection, *StaticSitesClientCreateOrUpdateBuildDatabaseConnectionOptions) (StaticSitesClientCreateOrUpdateBuildDatabaseConnectionResponse, error)` info [Changelog] - New function `*StaticSitesClient.CreateOrUpdateDatabaseConnection(context.Context, string, string, string, DatabaseConnection, *StaticSitesClientCreateOrUpdateDatabaseConnectionOptions) (StaticSitesClientCreateOrUpdateDatabaseConnectionResponse, error)` info [Changelog] - New function `*StaticSitesClient.DeleteBuildDatabaseConnection(context.Context, string, string, string, string, *StaticSitesClientDeleteBuildDatabaseConnectionOptions) (StaticSitesClientDeleteBuildDatabaseConnectionResponse, error)` info [Changelog] - New function `*StaticSitesClient.DeleteDatabaseConnection(context.Context, string, string, string, *StaticSitesClientDeleteDatabaseConnectionOptions) (StaticSitesClientDeleteDatabaseConnectionResponse, error)` info [Changelog] - New function `*StaticSitesClient.GetBuildDatabaseConnection(context.Context, string, string, string, string, *StaticSitesClientGetBuildDatabaseConnectionOptions) (StaticSitesClientGetBuildDatabaseConnectionResponse, error)` info [Changelog] - New function `*StaticSitesClient.GetBuildDatabaseConnectionWithDetails(context.Context, string, string, string, string, *StaticSitesClientGetBuildDatabaseConnectionWithDetailsOptions) (StaticSitesClientGetBuildDatabaseConnectionWithDetailsResponse, error)` info [Changelog] - New function `*StaticSitesClient.NewGetBuildDatabaseConnectionsPager(string, string, string, *StaticSitesClientGetBuildDatabaseConnectionsOptions) *runtime.Pager[StaticSitesClientGetBuildDatabaseConnectionsResponse]` info [Changelog] - New function `*StaticSitesClient.NewGetBuildDatabaseConnectionsWithDetailsPager(string, string, string, *StaticSitesClientGetBuildDatabaseConnectionsWithDetailsOptions) *runtime.Pager[StaticSitesClientGetBuildDatabaseConnectionsWithDetailsResponse]` info [Changelog] - New function `*StaticSitesClient.GetDatabaseConnection(context.Context, string, string, string, *StaticSitesClientGetDatabaseConnectionOptions) (StaticSitesClientGetDatabaseConnectionResponse, error)` info [Changelog] - New function `*StaticSitesClient.GetDatabaseConnectionWithDetails(context.Context, string, string, string, *StaticSitesClientGetDatabaseConnectionWithDetailsOptions) (StaticSitesClientGetDatabaseConnectionWithDetailsResponse, error)` info [Changelog] - New function `*StaticSitesClient.NewGetDatabaseConnectionsPager(string, string, *StaticSitesClientGetDatabaseConnectionsOptions) *runtime.Pager[StaticSitesClientGetDatabaseConnectionsResponse]` info [Changelog] - New function `*StaticSitesClient.NewGetDatabaseConnectionsWithDetailsPager(string, string, *StaticSitesClientGetDatabaseConnectionsWithDetailsOptions) *runtime.Pager[StaticSitesClientGetDatabaseConnectionsWithDetailsResponse]` info [Changelog] - New function `*StaticSitesClient.UpdateBuildDatabaseConnection(context.Context, string, string, string, string, DatabaseConnectionPatchRequest, *StaticSitesClientUpdateBuildDatabaseConnectionOptions) (StaticSitesClientUpdateBuildDatabaseConnectionResponse, error)` info [Changelog] - New function `*StaticSitesClient.UpdateDatabaseConnection(context.Context, string, string, string, DatabaseConnectionPatchRequest, *StaticSitesClientUpdateDatabaseConnectionOptions) (StaticSitesClientUpdateDatabaseConnectionResponse, error)` info [Changelog] - New function `*WebAppsClient.DeployWorkflowArtifacts(context.Context, string, string, *WebAppsClientDeployWorkflowArtifactsOptions) (WebAppsClientDeployWorkflowArtifactsResponse, error)` info [Changelog] - New function `*WebAppsClient.DeployWorkflowArtifactsSlot(context.Context, string, string, string, *WebAppsClientDeployWorkflowArtifactsSlotOptions) (WebAppsClientDeployWorkflowArtifactsSlotResponse, error)` info [Changelog] - New function `*WebAppsClient.GetInstanceWorkflowSlot(context.Context, string, string, string, string, *WebAppsClientGetInstanceWorkflowSlotOptions) (WebAppsClientGetInstanceWorkflowSlotResponse, error)` info [Changelog] - New function `*WebAppsClient.GetWorkflow(context.Context, string, string, string, *WebAppsClientGetWorkflowOptions) (WebAppsClientGetWorkflowResponse, error)` info [Changelog] - New function `*WebAppsClient.ListInstanceWorkflowsConfigurationConnectionsSlot(context.Context, string, string, string, string, *WebAppsClientListInstanceWorkflowsConfigurationConnectionsSlotOptions) (WebAppsClientListInstanceWorkflowsConfigurationConnectionsSlotResponse, error)` info [Changelog] - New function `*WebAppsClient.NewListInstanceWorkflowsSlotPager(string, string, string, *WebAppsClientListInstanceWorkflowsSlotOptions) *runtime.Pager[WebAppsClientListInstanceWorkflowsSlotResponse]` info [Changelog] - New function `*WebAppsClient.ListWorkflowsConfiguration(context.Context, string, string, string, *WebAppsClientListWorkflowsConfigurationOptions) (WebAppsClientListWorkflowsConfigurationResponse, error)` info [Changelog] - New function `*WebAppsClient.NewListWorkflowsPager(string, string, *WebAppsClientListWorkflowsOptions) *runtime.Pager[WebAppsClientListWorkflowsResponse]` info [Changelog] - New struct `DatabaseConnection` info [Changelog] - New struct `DatabaseConnectionCollection` info [Changelog] - New struct `DatabaseConnectionOverview` info [Changelog] - New struct `DatabaseConnectionPatchRequest` info [Changelog] - New struct `DatabaseConnectionPatchRequestProperties` info [Changelog] - New struct `DatabaseConnectionProperties` info [Changelog] - New struct `StaticSiteDatabaseConnectionConfigurationFileOverview` info [Changelog] - New struct `WorkflowArtifacts` info [Changelog] - New struct `WorkflowEnvelope` info [Changelog] - New struct `WorkflowEnvelopeCollection` info [Changelog] - New struct `WorkflowEnvelopeProperties` info [Changelog] - New struct `WorkflowHealth` info [Changelog] - New field `IPSecurityRestrictionsDefaultAction` in struct `SiteConfig` info [Changelog] - New field `Metadata` in struct `SiteConfig` info [Changelog] - New field `ScmIPSecurityRestrictionsDefaultAction` in struct `SiteConfig` info [Changelog] - New field `ManagedEnvironmentID` in struct `SiteProperties` info [Changelog] - New field `DatabaseConnections` in struct `StaticSite` info [Changelog] - New field `DatabaseConnections` in struct `StaticSiteBuildARMResourceProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 58 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 58a72ad8ff910cd68f59155faf5dcb09e6d03946. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️@azure/arm-appservice [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - Added Interface StaticSitesGetDatabaseConnectionWithDetailsOptionalParams info [Changelog] - Added Interface StaticSitesUpdateBuildDatabaseConnectionOptionalParams info [Changelog] - Added Interface StaticSitesUpdateDatabaseConnectionOptionalParams info [Changelog] - Added Interface WebAppsDeployWorkflowArtifactsOptionalParams info [Changelog] - Added Interface WebAppsDeployWorkflowArtifactsSlotOptionalParams info [Changelog] - Added Interface WebAppsGetInstanceWorkflowSlotOptionalParams info [Changelog] - Added Interface WebAppsGetWorkflowOptionalParams info [Changelog] - Added Interface WebAppsListInstanceWorkflowsConfigurationConnectionsSlotOptionalParams info [Changelog] - Added Interface WebAppsListInstanceWorkflowsSlotNextOptionalParams info [Changelog] - Added Interface WebAppsListInstanceWorkflowsSlotOptionalParams info [Changelog] - Added Interface WebAppsListWorkflowsConfigurationOptionalParams info [Changelog] - Added Interface WebAppsListWorkflowsNextOptionalParams info [Changelog] - Added Interface WebAppsListWorkflowsOptionalParams info [Changelog] - Added Interface WorkflowArtifacts info [Changelog] - Added Interface WorkflowEnvelope info [Changelog] - Added Interface WorkflowEnvelopeCollection info [Changelog] - Added Interface WorkflowEnvelopeProperties info [Changelog] - Added Interface WorkflowHealth info [Changelog] - Added Type Alias DefaultAction info [Changelog] - Added Type Alias ProviderOsTypeSelected info [Changelog] - Added Type Alias ProviderStackOsType info [Changelog] - Added Type Alias StaticSitesCreateOrUpdateBuildDatabaseConnectionResponse info [Changelog] - Added Type Alias StaticSitesCreateOrUpdateDatabaseConnectionResponse info [Changelog] - Added Type Alias StaticSitesGetBuildDatabaseConnectionResponse info [Changelog] - Added Type Alias StaticSitesGetBuildDatabaseConnectionsNextResponse info [Changelog] - Added Type Alias StaticSitesGetBuildDatabaseConnectionsResponse info [Changelog] - Added Type Alias StaticSitesGetBuildDatabaseConnectionsWithDetailsNextResponse info [Changelog] - Added Type Alias StaticSitesGetBuildDatabaseConnectionsWithDetailsResponse info [Changelog] - Added Type Alias StaticSitesGetBuildDatabaseConnectionWithDetailsResponse info [Changelog] - Added Type Alias StaticSitesGetDatabaseConnectionResponse info [Changelog] - Added Type Alias StaticSitesGetDatabaseConnectionsNextResponse info [Changelog] - Added Type Alias StaticSitesGetDatabaseConnectionsResponse info [Changelog] - Added Type Alias StaticSitesGetDatabaseConnectionsWithDetailsNextResponse info [Changelog] - Added Type Alias StaticSitesGetDatabaseConnectionsWithDetailsResponse info [Changelog] - Added Type Alias StaticSitesGetDatabaseConnectionWithDetailsResponse info [Changelog] - Added Type Alias StaticSitesUpdateBuildDatabaseConnectionResponse info [Changelog] - Added Type Alias StaticSitesUpdateDatabaseConnectionResponse info [Changelog] - Added Type Alias WebAppsGetInstanceWorkflowSlotResponse info [Changelog] - Added Type Alias WebAppsGetWorkflowResponse info [Changelog] - Added Type Alias WebAppsListInstanceWorkflowsConfigurationConnectionsSlotResponse info [Changelog] - Added Type Alias WebAppsListInstanceWorkflowsSlotNextResponse info [Changelog] - Added Type Alias WebAppsListInstanceWorkflowsSlotResponse info [Changelog] - Added Type Alias WebAppsListWorkflowsConfigurationResponse info [Changelog] - Added Type Alias WebAppsListWorkflowsNextResponse info [Changelog] - Added Type Alias WebAppsListWorkflowsResponse info [Changelog] - Added Type Alias WorkflowHealthState info [Changelog] - Interface Site has a new optional parameter managedEnvironmentId info [Changelog] - Interface SiteConfig has a new optional parameter ipSecurityRestrictionsDefaultAction info [Changelog] - Interface SiteConfig has a new optional parameter metadata info [Changelog] - Interface SiteConfig has a new optional parameter scmIpSecurityRestrictionsDefaultAction info [Changelog] - Interface SiteConfigResource has a new optional parameter ipSecurityRestrictionsDefaultAction info [Changelog] - Interface SiteConfigResource has a new optional parameter metadata info [Changelog] - Interface SiteConfigResource has a new optional parameter scmIpSecurityRestrictionsDefaultAction info [Changelog] - Interface StaticSiteARMResource has a new optional parameter databaseConnections info [Changelog] - Interface StaticSiteBuildARMResource has a new optional parameter databaseConnections info [Changelog] - Interface StaticSitePatchResource has a new optional parameter databaseConnections info [Changelog] - Added Enum KnownDefaultAction info [Changelog] - Added Enum KnownProviderOsTypeSelected info [Changelog] - Added Enum KnownProviderStackOsType info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface AppServiceEnvironmentsListUsagesNextOptionalParams no longer has parameter filter info [Changelog] - Interface AppServiceEnvironmentsListWebAppsNextOptionalParams no longer has parameter propertiesToInclude info [Changelog] - Interface AppServicePlansListNextOptionalParams no longer has parameter detailed info [Changelog] - Interface AppServicePlansListUsagesNextOptionalParams no longer has parameter filter info [Changelog] - Interface AppServicePlansListWebAppsNextOptionalParams no longer has parameter filter info [Changelog] - Interface AppServicePlansListWebAppsNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface AppServicePlansListWebAppsNextOptionalParams no longer has parameter top info [Changelog] - Interface CertificatesListNextOptionalParams no longer has parameter filter info [Changelog] - Interface ListBillingMetersNextOptionalParams no longer has parameter billingLocation info [Changelog] - Interface ListBillingMetersNextOptionalParams no longer has parameter osType info [Changelog] - Interface ListCustomHostNameSitesNextOptionalParams no longer has parameter hostname info [Changelog] - Interface ListGeoRegionsNextOptionalParams no longer has parameter linuxDynamicWorkersEnabled info [Changelog] - Interface ListGeoRegionsNextOptionalParams no longer has parameter linuxWorkersEnabled info [Changelog] - Interface ListGeoRegionsNextOptionalParams no longer has parameter sku info [Changelog] - Interface ListGeoRegionsNextOptionalParams no longer has parameter xenonWorkersEnabled info [Changelog] - Interface ProviderGetAvailableStacksNextOptionalParams no longer has parameter osTypeSelected info [Changelog] - Interface ProviderGetAvailableStacksOnPremNextOptionalParams no longer has parameter osTypeSelected info [Changelog] - Interface ProviderGetFunctionAppStacksForLocationNextOptionalParams no longer has parameter stackOsType info [Changelog] - Interface ProviderGetFunctionAppStacksNextOptionalParams no longer has parameter stackOsType info [Changelog] - Interface ProviderGetWebAppStacksForLocationNextOptionalParams no longer has parameter stackOsType info [Changelog] - Interface ProviderGetWebAppStacksNextOptionalParams no longer has parameter stackOsType info [Changelog] - Interface RecommendationsListHistoryForHostingEnvironmentNextOptionalParams no longer has parameter expiredOnly info [Changelog] - Interface RecommendationsListHistoryForHostingEnvironmentNextOptionalParams no longer has parameter filter info [Changelog] - Interface RecommendationsListHistoryForWebAppNextOptionalParams no longer has parameter expiredOnly info [Changelog] - Interface RecommendationsListHistoryForWebAppNextOptionalParams no longer has parameter filter info [Changelog] - Interface RecommendationsListNextOptionalParams no longer has parameter featured info [Changelog] - Interface RecommendationsListNextOptionalParams no longer has parameter filter info [Changelog] - Interface RecommendationsListRecommendedRulesForHostingEnvironmentNextOptionalParams no longer has parameter featured info [Changelog] - Interface RecommendationsListRecommendedRulesForHostingEnvironmentNextOptionalParams no longer has parameter filter info [Changelog] - Interface RecommendationsListRecommendedRulesForWebAppNextOptionalParams no longer has parameter featured info [Changelog] - Interface RecommendationsListRecommendedRulesForWebAppNextOptionalParams no longer has parameter filter info [Changelog] - Interface WebAppsListByResourceGroupNextOptionalParams no longer has parameter includeSlots info [Changelog] - Interface WebAppsListPerfMonCountersNextOptionalParams no longer has parameter filter info [Changelog] - Interface WebAppsListPerfMonCountersSlotNextOptionalParams no longer has parameter filter info [Changelog] - Interface WebAppsListUsagesNextOptionalParams no longer has parameter filter info [Changelog] - Interface WebAppsListUsagesSlotNextOptionalParams no longer has parameter filter info [Changelog] - Interface WorkflowRunActionsListNextOptionalParams no longer has parameter filter info [Changelog] - Interface WorkflowRunActionsListNextOptionalParams no longer has parameter top info [Changelog] - Interface WorkflowRunsListNextOptionalParams no longer has parameter filter info [Changelog] - Interface WorkflowRunsListNextOptionalParams no longer has parameter top info [Changelog] - Interface WorkflowTriggerHistoriesListNextOptionalParams no longer has parameter filter info [Changelog] - Interface WorkflowTriggerHistoriesListNextOptionalParams no longer has parameter top info [Changelog] - Interface WorkflowTriggersListNextOptionalParams no longer has parameter filter info [Changelog] - Interface WorkflowTriggersListNextOptionalParams no longer has parameter top info [Changelog] - Interface WorkflowVersionsListNextOptionalParams no longer has parameter top info [Changelog] - Type of parameter osTypeSelected of interface ProviderGetAvailableStacksOnPremOptionalParams is changed from Enum19 to ProviderOsTypeSelected info [Changelog] - Type of parameter osTypeSelected of interface ProviderGetAvailableStacksOptionalParams is changed from Enum14 to ProviderOsTypeSelected info [Changelog] - Type of parameter stackOsType of interface ProviderGetFunctionAppStacksForLocationOptionalParams is changed from Enum16 to ProviderStackOsType info [Changelog] - Type of parameter stackOsType of interface ProviderGetFunctionAppStacksOptionalParams is changed from Enum15 to ProviderStackOsType info [Changelog] - Type of parameter stackOsType of interface ProviderGetWebAppStacksForLocationOptionalParams is changed from Enum17 to ProviderStackOsType info [Changelog] - Type of parameter stackOsType of interface ProviderGetWebAppStacksOptionalParams is changed from Enum18 to ProviderStackOsType info [Changelog] - Removed Enum KnownEnum14 info [Changelog] - Removed Enum KnownEnum15 info [Changelog] - Removed Enum KnownEnum16 info [Changelog] - Removed Enum KnownEnum17 info [Changelog] - Removed Enum KnownEnum18 info [Changelog] - Removed Enum KnownEnum19 info [Changelog] - Removed Enum KnownWorkflowState
️🔄 azure-resource-manager-schemas inProgress [Detail]
️❌ azure-powershell failed [Detail]
❌Failed [Logs] Generate from 58a72ad8ff910cd68f59155faf5dcb09e6d03946. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.web [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| swagger | Microsoft.CertificateRegistration | Create ApiView failed. Please ask PR assignee for help |
| Go | sdk/resourcemanager/appservice/armappservice | https://apiview.dev/Assemblies/Review/e846eb5efe1740edb1b59faadb4f0dea |
| Java | azure-resourcemanager-appservice-generated | https://apiview.dev/Assemblies/Review/3ba492147f464aafb51015aca6518fee |
| JavaScript | @azure/arm-appservice | https://apiview.dev/Assemblies/Review/d0d165aa893645dc9eec56fbcd1ad365 |
@naveedaz I don't know why but I cannot add you to reviewer. (seems to be some permission problem?)
Hi @joslinmicrosoft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
Hi, @joslinmicrosoft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).
}
Common parameters best practice - use $ref to common types There are definitions of common parameters in common-types/v3/types.json that you can use by $ref instead of declaring your own, like SubscriptionIdParameter, OperationIdParameter, and ApiVersionParameter, See https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L630
In reply to: 1382665016
Refers to: specification/web/resource-manager/Microsoft.Web/stable/2022-09-01/StaticSites.json:5375 in c73d7d9. [](commit_id = c73d7d9035fef18ef74ade17e5975fd5f66fe114, deletion_comment = False)
"description": "Identity to use for Key Vault Reference authentication.",
What format? Is it a resource id, or a guid, or what?
Refers to: specification/web/resource-manager/Microsoft.Web/stable/2022-09-01/StaticSites.json:4301 in c73d7d9. [](commit_id = c73d7d9035fef18ef74ade17e5975fd5f66fe114, deletion_comment = False)
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested
}Common parameters best practice - use common types There are definitions of common parameters in common-types/v3/types.json that you can use by $ref instead of declaring your own, like SubscriptionIdParameter, OperationIdParameter, and ApiVersionParameter, See
https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L630
Refers to: specification/web/resource-manager/Microsoft.Web/stable/2022-09-01/StaticSites.json:5375 in c73d7d9. [](commit_id = c73d7d9, deletion_comment = False)
@TimLovellSmith regarding this, as this pattern is used across our broader team I would need to defer to @naveedaz for how we would want to adress this.
"description": "Identity to use for Key Vault Reference authentication.",What format? Is it a resource id, or a guid, or what?
Refers to: specification/web/resource-manager/Microsoft.Web/stable/2022-09-01/StaticSites.json:4301 in c73d7d9. [](commit_id = c73d7d9, deletion_comment = False)
I've updated the description for connectionIdentity to clarify this. I am leaving existing APIs as is to limit the scope of this PR to just the addition of the database connection APIs
In reply to: 1383235428
@TimLovellSmith thank you for the review, I've addressed some of your comments with pushed changes and others added some more discussion. I'm unable to remove the ARMChangesRequested tag, can you or maybe @weidongxu-microsoft help with that to continue with the review?
I've pushed some more updates to address the latest PR comments, @weidongxu-microsoft do you mind updating the labels again for me so I can get another review on this? Thanks!
Hi @TimLovellSmith @raosuhas @weidongxu-microsoft I've addressed the comments and gotten the required checks to pass. Is there anything else pending or can we merge this PR?
@joslinmicrosoft
I see Tim has a change request on the PR, so I will wait a bit for him to check again.
Do you have approval from Navy's team (owner of release-web-Microsoft.Web-2022-09-01 branch)?
I should be able to merge after above responded/solved.
@TimLovellSmith do you mind giving another review (since we're currently blocking on the requested changes)?
@weidongxu-microsoft I will check in with Navy, thanks!
Hi @TimLovellSmith, your change requests are either updated by service, or explained in details. Could you check again, that whether the PR is acceptable to you.
"description": "Identity to use for Key Vault Reference authentication.",
To be clear, I'm just asking you to be specific in the description, as I consider this not clear enough to understand without also reading the examples.
In reply to: 1382665064
Refers to: specification/web/resource-manager/Microsoft.Web/stable/2022-09-01/StaticSites.json:4301 in c73d7d9. [](commit_id = c73d7d9035fef18ef74ade17e5975fd5f66fe114, deletion_comment = False)
"description": "Identity to use for Key Vault Reference authentication.",
I don't see this property in the examples in this PR BTW?
In reply to: 1432561416
Refers to: specification/web/resource-manager/Microsoft.Web/stable/2022-09-01/StaticSites.json:4301 in c73d7d9. [](commit_id = c73d7d9035fef18ef74ade17e5975fd5f66fe114, deletion_comment = False)
"description": "Identity to use for Key Vault Reference authentication.",To be clear, I'm just asking you to be specific in the description, as I consider this not clear enough to understand without also reading the examples.
In reply to: 1382665064
Refers to: specification/web/resource-manager/Microsoft.Web/stable/2022-09-01/StaticSites.json:4301 in c73d7d9. [](commit_id = c73d7d9, deletion_comment = False)
Gotcha, yes I understand the feedback but I'm saying that this is out of scope for this PR. The keyVaultReferenceIdentity is part of an existing API, I can update it in a separate PR but would like to keep this one focused to database connections APIs only if that's ok.
Thanks again @TimLovellSmith, @weidongxu-microsoft. Can you please give one more review and if all is good merge? Thanks!
Oh, sorry I've merged it before Tim get a chance to provide more feedbacks.
@joslinmicrosoft Since the target is a feature branch, if Tim give more feedback that you think should be included, please raise a follow-up PR.