ThrawnCA

Results 345 comments of ThrawnCA

> But why did it take a change in java version to start reporting? I couldn't say for certain, but perhaps a difference in the resulting bytecode?

Actually there's a whole new artifact, `com.mebigfatguy.sb-contrib:sb-contrib`.

No, I can't see anything wrong with the sample, but the detector is still firing for me. I've tried altering my compiler configuration (switched between JDK7 and 8, toggled debug...

I'm still seeing this - including for an exact copy of the code in the sample `GitHubIssue207` class - with version 7.4.0.sb.

I'm not enough of an expert to read this properly, but it looks like UnitTestAssertionOddities will only record this bug when it thinks it has seen a negated equals expression....

The superclass is from a third party (Hibernate), but I can provide `javap` output for ours: Classfile /osidt/common/target/classes/au/gov/qld/ssq/common/repository/MoneyUserType$MoneyTypeDescriptor.class Last modified 16/08/2019; size 3687 bytes MD5 checksum 82d479344260a00d53a8b7129d5df83a Compiled from "MoneyUserType.java"...

Hmm, looks like you're right. We had an exclusion rule for that, but maybe it's outdated now.

Well, given that there's a conflict between Checkstyle's expectations and fb-contrib's, it might make just as much sense to change Checkstyle. I expect that you could find plenty of advocates...

The SourceForge page isn't really maintained anymore; it points you toward the GitHub page, which mentions the different versions for FindBugs vs SpotBugs. Which link in particular did you find...

Those links are correct for fb-contrib, though, and the page does say that it's meant to be used with FindBugs (not SpotBugs). I suppose it wouldn't hurt for there to...