Matt Corallo
Matt Corallo
As we already have pretty decent benchmark coverage, I imagine the real work here is somehow start benchmarking memory usage and disk footprint.
I do kinda prefer we re-export somewhere, and given our current paths are `lightning::ln::types` I don't see much reason to jump to remove that, but we could definitely move it...
So maybe we re-export it as `lightning::types` now and deprecate (if possible) the `ln::types` exports?
IMO we already have a good bit of API breakage in this release, it'd be kinda nice to put off yet more until the next one.
I don't see much reason to move `ChannelId` to `lightning-types`, and sadly doing so is pretty irritating cause it has several in-crate dependencies.
Sadly `ChannelId` depends on things in `lightning` so I don't think that's super practical. I did take a look through `ln-types` and it doesn't look like there's really much there...
Yea, I was mostly referring to not wanting to deal with extension traits, which make docs super confusing for people :/.
Untagging from 0.0.124 post-#3253, but moving to 0.1 to resolve the deprecateds by removing the old re-exports.
Oops, github was a bit eager. We made more progress, but sadly #3359 deprecated one more set of exports which we'll want to remove in 0.2...