Ben Kochie

Results 1558 comments of Ben Kochie

Maybe this should be a command line flag and not something reloadable?

Hey, FYI, I am going to revert part of this. This does not actually update the Go version to 1.24. This is controlled by the `.promu.yml` config and our CI...

Updating to Go 1.24 was already completed in https://github.com/prometheus/memcached_exporter/pull/255.

@roidelapluie if you have a chance to look. It seems like Go has disabled some more TLS options. Should I just remove the broken tests?

This is somewhat mitigated by fully-qualified OID specifications.

@roidelapluie I don't know @bboreham Do you have any suggested wording changes?

@gotjosh Nice, thanks

Of course, you don't need to ask permission to work on open source.

I'm not too concerned about the data exposure here. Like @lapo-luchini says, the exposure values would be up to the admin's regexp. The concern #1098 and similar are the ability...

@matthiasr Isn't that already captured by `scrape_samples_scraped` and `scrape_samples_post_metric_relabeling`?