Ben Kochie

Results 1558 comments of Ben Kochie

Other options: * Allow configuration or reduce the default number of histogram buckets. * For users that really want to know about requests by `resource_namespace`, we could keep that label...

Maybe worth reverting OpenTelemetry for metrics and switching back to Prometheus client_golang. It's a much more stable library.

It would be useful to add tests for this.

Hmmm, I thought I added the credentials to prometheus-community CI already. Let me take a look.

This seems like it would generate a lot of label value churn. I'm not sure this is something we would want to add.

One nice thing to do would be to squash your commits into logical changes. Rather than have a bunch of "Fix typo" changes.

Yes, you can rebase/sqaush/change whenever you feel like.

This needs a DCO sign-off. You can use `git commit -s --amend` to add it.