client_golang icon indicating copy to clipboard operation
client_golang copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

Fix up min/max identifiers

Open SuperQ opened this issue 1 year ago • 3 comments

Go now includes min and max in the list of predeclared identifiers. These need to be renamed.

Followup to https://github.com/prometheus/client_golang/pull/1603

SuperQ avatar Aug 30 '24 16:08 SuperQ

May I take on this issue?

parthlaw avatar Aug 30 '24 18:08 parthlaw

Of course, you don't need to ask permission to work on open source.

SuperQ avatar Aug 31 '24 04:08 SuperQ

@SuperQ please take a look at the PR and let me know if this is the solution that we were looking for.

parthlaw avatar Aug 31 '24 09:08 parthlaw

Fixed by https://github.com/prometheus/client_golang/pull/1606

ArthurSens avatar Mar 28 '25 12:03 ArthurSens