Ben Kochie

Results 1558 comments of Ben Kochie

Nice, I like it so far. I haven't had a chance to evaluate the parser libraries.

I personally prefer strftime style parsing. I sent a couple of PRs to https://github.com/lestrrat-go/strftime to see if the maintainer is still active. What do you think @bastischubert? Do you prefer...

I looked over https://github.com/lestrrat-go/strftime, it seems reasonable. I'm fine with either library, but I live a slight preference for strftime.

Adding multiple parser options is probably a bit more complexity than necessary. I'd like to start with one parser and see how things evolve.

Try with the latest (0.26.0) generator, it has improved error handling in the MIB parser.

Interesting, I am able to reproduce the error. I had to find the MIB on another site as `circitor.fr` is down. I'll have to spend some time to figure out...

I think this would be a great idea. The resulting output should follow the Prometheus convention of returning a UNIX epoch timestamp in seconds as the value. Personally I would...

We can do some more research on time parse libraries. That is a small component to swap out.

Good idea, minor nit about the test setup.

We support `ContextName`, is that sufficient?