Stephan Schroevers

Results 104 comments of Stephan Schroevers

Tnx for the input @cushon! I'll give some thought to the flag names. Planned to have a look at this PR this weekend, but it didn't happen. Will hopefully circle...

Hi @therealppa! Thanks for the feedback; indeed we should do better in this regard. We're working on several initiatives to derive better documentation from the code; that should make it...

Hey @patpatpat123! I'm not an Error Prone maintainer, so the following is not an official answer, but it may help: 1. Having a separate plugin would be nice, but Error...

This PR is now on top of #13, for otherwise the build fails.

Rebased and added a small commit; recent changes LGTM.

Resolved a whole bunch of conflicts. I did need to suppress some `ErrorProneRuntimeClasspath` false positives; that should be tackled in a separate PR.

Great topic. Some n=1 feedback: all Picnic-internal code targets JDK 17. For [Error Prone Support](https://github.com/PicnicSupermarket/error-prone-support) we kept the baseline at JDK 11, but that does impede the use of text...

> Seems PiTest in CI consistently fails in ~1m w/ > > ``` > Failed to execute goal org.pitest:pitest-maven:1.15.3:mutationCoverage (default-cli) on project error-prone-contrib: Execution default-cli of goal org.pitest:pitest-maven:1.15.3:mutationCoverage failed: Coverage...

Good detective work :). To catch this kind of issue at build time, consider using the [maven-enforcer-plugin](https://maven.apache.org/enforcer/maven-enforcer-plugin/) with the [dependencyConvergence](https://maven.apache.org/enforcer/enforcer-rules/dependencyConvergence.html) or even the [requireUpperBoundDeps](https://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html) rule.

@dylanbaroody if I understand the question correctly (I didn't re-read the whole thread): yes, the alternative is to pass the relevant flags to the Maven process itself, e.g. by placing...