Stephan Schroevers

> The google-java-format tool doesn't support overriding the indentation. I added a comment on PR #1379; seems four space indentation should be possible after all :).

Relates to #1610. The common theme seems to be that the check should match in fewer places, roughly speaking only when: 1. the obsolete type is explicitly constructed, except in...

Rebased and squashed the two commits, as I'll cherry-pick the changes of this PR to our fork. That said: still interested in seeing this included in mainline Error Prone :upside_down_face:.

@delanym this sounds similar to #1562, which was fixed in #3236. IIUC that change hasn't been released yet.

> @Stephan202 it looks like it hasn't been merged either?? It was merged; see ad0289b0251293d73c5ea62a5f165bba8577b3a7, which is on `master`. (The Github PR status is misleading; that's merely an artifact of...

In theory this behavior could also be achieved by omitting `ParameterMissingNullable` from the test compilation Error Prone arguments. But that can be annoying to configure in e.g. Maven (it'd likely...

> add an option to apply the patch directly on the source files as with git this simply shows up as changes to the working tree and can be applied/rejected...

> Is it ONLY MissingOverrides and DefaultCharset? Nope. Most Error Prone checks come with a [suggested fix](https://github.com/google/error-prone/search?q=suggestedfix). In general, if an error or warning message contains a "Did you mean"...

+1, but I already filed #922 for this ;) (Not sure to what extend the classpath issue I mention there is still applicable, as many things changed in the past...

(Ex-colleague of @hisener here :upside_down_face:.) We hit a similar issue in the past with a large build running on Travis CI. I looked up the relevant commit and found this...