Stephan Schroevers

Results 104 comments of Stephan Schroevers

Error Prone 2.3.2 is nearly 3.5 years old; please upgrade to see whether this issue has been resolved already. (Looks like this might have been fixed by #780.)

There is precedent for supporting this format; see MomentJS: moment/moment#2955. Our mixed Java-Python team would benefit from this as well.

This error appears to be a client-side issue. So it seems more appropriate to log the message at a lower level altogether; certainly no higher than WARN. If you agree...

@mraible: I filed #1313. Happy to tweak the PR as required; I can see there may be various opinions/preferences around this topic.

Rebased. Would still be nice to get this PR merged :)

@frant-hartm thanks for breathing some life into this PR! You're totally right that the `synchronized (SortedMap.class)` construct was dodgy; thanks for calling that out :) I cherry-picked your changes to...

@bjanczak there's a PR for this issue (#355), but this plugin does not appear to be actively maintained :disappointed: . We're also still hitting this issue frequently. Can one of...

@wykapedia, as far as I'm concerned: please go ahead :) (Although I opened the issue and indicated I'd be fine producing a PR, I won't have time for this in...

IIUC, a variant of this issue is the following case: ``` $ javac PackagePrivateClass.java $ cat -n PackagePrivateClass.java 1 final class PackagePrivateClass { 2 public static abstract class AbstractServiceLoadableClass {...

@romani I'm referring to Java's [service loading](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/ServiceLoader.html) mechanism, which [requires](https://github.com/openjdk/jdk/blob/739fdec7ea44be7ab12fdf418793276d581e58fe/src/java.base/share/classes/java/util/ServiceLoader.java#L654-L682) that types of instances loaded through [`ServiceLoader.load(Class)`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/ServiceLoader.html#load(java.lang.Class)) are public and have a public constructor. That said, I did misspeak in...