Stephan Schroevers
Stephan Schroevers
Rebased, resolved conflicts, and made the changes more compatible with Jabel.
Rebased and resolved conflicts and other issues. The PR now targets `master`. Next up would be to get the code in a reviewable state, primarily by extending test coverage. One...
> I also pushed a formatting change suggested by GJF, but it looks off; we may want to flag this upstream. I filed google/google-java-format#1081.
> > I also pushed a formatting change suggested by GJF, but it looks off; we may want to flag this upstream. > > I filed [google/google-java-format#1081](https://github.com/google/google-java-format/issues/1081). A fix for...
I was reminded of this PR because the issue it attempts to fix happened again. @bjanczak @lama0206 @frant-hartm WDYT of the current state of the PR, and/or do you happen...
@rholder, I'm willing to open a PR with the suggestions as outline above, but before I spend time on that I'd like to hear whether you agree with the described...
@kevinb9n exactly! I guess I should have summarized this more clearly myself.
Error Prone was also impacted by this limitation: google/error-prone#4040. Would still be nice to have `ImmutableRangeSet.Builder` support overlapping ranges. :pray:
@hcoles thanks for the quick response! Perhaps I misunderstand, but since execution of the impacted code is deferred, I would expect it to be excluded from the search. After all,...
@GiuseppeMP the difference between those two is that the latter also [pulls in](https://repo1.maven.org/maven2/org/junit/jupiter/junit-jupiter/5.10.2/junit-jupiter-5.10.2.pom) `junit-jupiter-engine` (and `junit-jupiter-params`, but that's not relevant here). So likely this is the same issue as what...