Stephan Schroevers

Results 190 comments of Stephan Schroevers

Hey @bmeier-pros! Does your issue match what's described in #1081?

I see this one sunk down way too far on my TODO list, out of sight :(. The coming weeks are very busy, so I can't commit. (But I did...

Tnx for filing this issue, @werli! To whomever picks this up: case (3) is not _always_ an issue, since a method source may be used by multiple `@ParameterizedTest` methods, some...

Thanks @vprudnikov; this is a nice idea. We'll have to assess which flag/config format works best, but technically this looks very doable :+1:. (Before making a decision on the flag...

Hey @jai-ramakrishnan! For this you'd add `-Xep:Refaster:OFF -XepOpt:Refaster:NamePattern=^NullRules\$.*` (The latter flag is a regex, so later you could e.g. do `-XepOpt:Refaster:NamePattern=^(MapRules|NullRules)\$.*`. Once you're ready to enable all-but-some rules, you can...

@jai-ramakrishnan it's not you, it's me :facepalm:. I wrote `-Xep:Refaster:OFF`, but of course that should be `-Xep:Refaster:ERROR` or `-Xep:Refaster:WARN`. Copy-paste error; sorry! Thanks for trying Error Prone Support!

Hey @vprudnikov! Thanks for reaching out. I can see how our documentation is confusing in this respect, but unfortunately only the _last_ `-XepOpt:Refaster:NamePattern` flag is respected. If you want to...

Thanks for the quick feedback @vprudnikov! I've relabelled this as a `documentation` issue. My plate is rather full right now, but "one of these days" I'll circle back to this...

Thanks for filing this issue @mohamedsamehsalah! One key point of feedback: I think we're looking for an analog of [`LexicographicalAnnotationAttributeListing`](https://github.com/PicnicSupermarket/error-prone-support/blob/b39e322a671deea549aff427976fa34f8d6e929b/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/LexicographicalAnnotationAttributeListing.java), i.e. a check that replaces `@A("foo", "bar", "foo")` with `@A("foo",...

W.r.t. your considerations: * I'm not sure how pointer references factor in, but since only primitives, enum values and strings can be annotation arguments, the invariant holds that a value...