Simon Frings

Results 115 comments of Simon Frings

@ReedyBear Thank you for your feature proposal, really appreciate all the work you put into explaining your ideas here :+1: > Would be good to know if you support this...

Whops, I accidentally commented in the wrong PR, but the test suite is currently failing so I'll take my approve back and re-request my review

@Moskito89 I talked with @clue about this and we don't have a clear answer yet. It makes totally sense to also support dotfiles, but including them by default feels like...

@Moskito89 I think adding this as an option avoids the current BC-break problem. I agree that the root files are a first good step for this, so I think it's...

@joecampo The milestone for the upcoming [`v4.1.0`](https://github.com/reactphp/async/milestone/4) is not completed yet, but we're working on this, so you can expect a release with the [`delay()` function](https://github.com/reactphp/async/pull/69) in the nearer future....

It also seems like the tests for HHVM are currently failing, didn't notice while reviewing. Can you look into this?

Seems like this has been answered, so I'll close this ticket for now. We can discuss further ideas for an integration in here and can always reopen if really necessary...

Hey @staabm, thanks for the input on this, seems like a reasonable change :+1: If this works as well as you described it above, than I agree that this is...

I opened a new pull request in #260 for this. The ongoing development in PHP 8.4 is currently breaking our test suite (changed stack trace -> failing `.phpt` test files),...

Hey @skydiablo, thanks for your contribution :+1: This is actually a design choice made in #315 which @clue also slightly described in #210. Here's a "short" example that showcases why...