Simon Frings comments

Results 115 comments of


                                            Simon Frings

ServerInstance socket not closing on unexpected program termination or loop stop

Hey @valzargaming, thanks for bringing this up and taking the time to properly explain your case :+1: I copied the example you posted above and tried to reproduce the behavior,...

Allow undescore character in Uri host

@lulhum Thanks for applying these changes :+1: Looks good to me so far. As a last step, can you squash the two commits into one? I don't think we need...

ServerInstance socket not closing on unexpected program termination or loop stop

@valzargaming thanks for giving additional input on this and sharing your results :+1: Seems to me that this is a problem laying outside of ReactPHP and has something to do...

Add native types to public API

> Last time I checked, those classes aren't part of our public API, except the Query/RetryExecutor. 🤣🤐🤦(But yes I'll add public types to those as well.) @WyriHaximus Yeah, I also...

Fix expected error code in tests when ext-sockets is not enabled

@lucasnetau Thanks for bringing this up :+1: Seems like a reasonable change to me, but I don't have at much insights on this as @clue and @WyriHaximus, so interested in...