Simon Frings

Results 115 comments of Simon Frings

Had a call with @clue and @WyriHaximus about this topic. We all agree that it is a good idea to activate discussions, the question is how to do it. It...

Hey @CViniciusSDias, thanks for all the input :+1: When it comes to working with the filesystem it gets a bit tricky. The problem is that the filesystem is inherently blocking,...

Beware not to take this sentence out of context. The full section of the documentation states: > Internally, this class tries to enable non-blocking mode on the stream resource which...

Hey @greendrake You're not wrong, the error message could be a bit more precise. If you already have some ideas we're always happy about pull requests. :+1:

Hey @jkrzefski, thanks for bringing this up :+1: This is something we also thought about when implementing the support for variables in container configuration for factory functions (#178, #179, #180,...

Hey @fiasco, I think [reactphp/child-process](https://github.com/reactphp/child-process) is what you're looking for. Forking can be a possibility here but there are many things you need to be careful about. For example, when...

@VasekPurchart Thanks for bringing this up :+1: Can you add additional tests to confirm that your changes work as expected.

@WyriHaximus This is very similar to #469, I see what you're planning to do with this PR, but I would again ask the question if it would be better to...

@kelunik thanks for the update 👍 The test itself in its functionality and the overall design looks great. I talked with @clue about this and it looks like your testcase...

@nhedger I really like this idea, I'm not sure what's the best way to do this. I see a problem with future contributions to the project. There can (and will...