Simon Frings

Results 115 comments of Simon Frings

@dinooo13 Nice, now you only need to squash your commits ;)

Nice one 👍 Have you also seen @clue's comment regarding the `README.md`? > Also, the documentation currently says "If the original request contained a request body, this request body will...

Hey @lucasnetau, thanks for the amazing work on this so far 👍 The HHVM tests are currently failing, you can look into it but I don't expect a fix for...

@lucasnetau I will look into MacOS, this is also the case for some other repositories, so expect a PR to fix this soon. After that the test suite should be...

Tests and functional changes are looking great :+1: > The only difference between a TcpTransportExecutor and a TlsTcpTransportExecutor would be the handshake that occurs at the beginning. I cannot see...

@lucasnetau I understand that, definitely feels wrong to just throw this away. I am also not the only one to decide over this, I am interested in what @WyriHaximus and...

Hey @ClosetMonkey, thanks for bringing this up :+1: Sounds like your suggesting that we implement some kind of fork support. This sounds like a good idea and we're always happy...

Nice read, I can tell you put quite some time into this topic :+1: > This all leads me to a few questions, but one is regarding your statement about...

@JoelFeiner @nnewton Like @clue said, this is already planned for the longer Roadmap, but nothing we're currently working on. If you have an idea on how to implement a feature...

Hey @maituduy, thanks for bringing this up :+1: As the [documentation for the `ThroughStream` class](https://github.com/reactphp/stream#throughstream) says, it passes any data you write to it through to its readable end. That...